From 57e8c44e81376866767f593b68ffb2fa802f9cdc Mon Sep 17 00:00:00 2001
From: Anders Kaseorg <anders@zulip.com>
Date: Tue, 9 Sep 2025 18:41:42 -0700
Subject: [PATCH] =?UTF-8?q?starlight=5Fhelp:=20Use=20=E2=80=98astro=20chec?=
 =?UTF-8?q?k=E2=80=99=20for=20development=20only.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Anders Kaseorg <anders@zulip.com>
---
 .github/workflows/zulip-ci.yml |  5 +++++
 pnpm-lock.yaml                 | 24 ++++++++++++------------
 starlight_help/package.json    | 11 ++++++-----
 tools/test-all                 |  1 +
 4 files changed, 24 insertions(+), 17 deletions(-)

diff --git a/.github/workflows/zulip-ci.yml b/.github/workflows/zulip-ci.yml
index 63c58b19a1..dcd4637f04 100644
--- a/.github/workflows/zulip-ci.yml
+++ b/.github/workflows/zulip-ci.yml
@@ -155,6 +155,11 @@ jobs:
           PYTHONWARNINGS=ignore ./tools/check-capitalization --no-generate
           PYTHONWARNINGS=ignore ./tools/check-frontend-i18n --no-generate
 
+      - name: Run astro check
+        if: ${{ matrix.include_frontend_tests }}
+        run: |
+          pnpm run --filter=starlight_help check
+
       - name: Run puppeteer tests
         if: ${{ matrix.include_frontend_tests }}
         run: |
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index e6b9d3093c..4f860e78d3 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -524,21 +524,12 @@ importers:
 
   starlight_help:
     dependencies:
-      '@astrojs/check':
-        specifier: ^0.9.3
-        version: 0.9.4(prettier-plugin-astro@0.14.1)(prettier@3.5.3)(typescript@5.9.2)
       '@astrojs/starlight':
         specifier: ^0.35.1
         version: 0.35.2(astro@5.13.5(@types/node@22.18.1)(encoding@0.1.13)(jiti@2.5.1)(rollup@4.50.0)(terser@5.44.0)(typescript@5.9.2)(yaml@2.8.1))
       '@iconify-json/fa':
         specifier: ^1.2.1
         version: 1.2.2
-      '@types/hast':
-        specifier: ^3.0.4
-        version: 3.0.4
-      '@types/mdast':
-        specifier: ^4.0.4
-        version: 4.0.4
       astro:
         specifier: ^5.1.2
         version: 5.13.5(@types/node@22.18.1)(encoding@0.1.13)(jiti@2.5.1)(rollup@4.50.0)(terser@5.44.0)(typescript@5.9.2)(yaml@2.8.1)
@@ -560,9 +551,6 @@ importers:
       sharp:
         specifier: ^0.34.1
         version: 0.34.3
-      typescript:
-        specifier: ^5.4.5
-        version: 5.9.2
       unist-util-visit:
         specifier: ^5.0.0
         version: 5.0.0
@@ -570,6 +558,15 @@ importers:
         specifier: ^22.1.0
         version: 22.2.0
     devDependencies:
+      '@astrojs/check':
+        specifier: ^0.9.3
+        version: 0.9.4(prettier-plugin-astro@0.14.1)(prettier@3.5.3)(typescript@5.9.2)
+      '@types/hast':
+        specifier: ^3.0.4
+        version: 3.0.4
+      '@types/mdast':
+        specifier: ^4.0.4
+        version: 4.0.4
       mdast-util-to-markdown:
         specifier: ^2.1.2
         version: 2.1.2
@@ -624,6 +621,9 @@ importers:
       remark-stringify:
         specifier: ^11.0.0
         version: 11.0.0
+      typescript:
+        specifier: ^5.4.5
+        version: 5.9.2
       unified:
         specifier: ^11.0.5
         version: 11.0.5
diff --git a/starlight_help/package.json b/starlight_help/package.json
index 767cc42e57..32f5120593 100644
--- a/starlight_help/package.json
+++ b/starlight_help/package.json
@@ -5,16 +5,14 @@
   "scripts": {
     "dev": "astro dev",
     "start": "astro dev",
-    "build": "astro check && astro build",
+    "check": "astro check",
+    "build": "astro build",
     "preview": "astro preview",
     "astro": "astro"
   },
   "dependencies": {
-    "@astrojs/check": "^0.9.3",
     "@astrojs/starlight": "^0.35.1",
     "@iconify-json/fa": "^1.2.1",
-    "@types/hast": "^3.0.4",
-    "@types/mdast": "^4.0.4",
     "astro": "^5.1.2",
     "hast-util-from-html": "^2.0.3",
     "hast-util-to-html": "^9.0.5",
@@ -22,11 +20,13 @@
     "remark": "^15.0.1",
     "remark-mdx": "^3.1.0",
     "sharp": "^0.34.1",
-    "typescript": "^5.4.5",
     "unist-util-visit": "^5.0.0",
     "unplugin-icons": "^22.1.0"
   },
   "devDependencies": {
+    "@astrojs/check": "^0.9.3",
+    "@types/hast": "^3.0.4",
+    "@types/mdast": "^4.0.4",
     "mdast-util-to-markdown": "^2.1.2",
     "remark-frontmatter": "^5.0.0",
     "remark-gfm": "^4.0.1",
@@ -45,6 +45,7 @@
     "remark-preset-lint-markdown-style-guide": "^6.0.1",
     "remark-preset-lint-recommended": "^7.0.1",
     "remark-stringify": "^11.0.0",
+    "typescript": "^5.4.5",
     "unified": "^11.0.5",
     "unified-lint-rule": "^3.0.1"
   }
diff --git a/tools/test-all b/tools/test-all
index d01a3df9dd..c9c5a03a90 100755
--- a/tools/test-all
+++ b/tools/test-all
@@ -74,6 +74,7 @@ run ./tools/check-schemas
 run ./manage.py makemessages --locale en
 run env PYTHONWARNINGS=ignore ./tools/check-capitalization --no-generate
 run env PYTHONWARNINGS=ignore ./tools/check-frontend-i18n --no-generate
+run pnpm run --filter=starlight_help check
 run ./tools/test-js-with-puppeteer "${forcearg[@]}"
 
 printf '\n\e[32mAll OK!\e[0m\n'