From 588f34e02f52fae3a77829d87d73f48c1316555f Mon Sep 17 00:00:00 2001 From: Steve Howell Date: Sat, 18 Jan 2020 12:11:06 +0000 Subject: [PATCH] node tests: Remove complicated topic_list test. This test mostly tests how we glue everything together, but I want to change that in an upcoming commit. Also, the data stuff that it tests is now better covered by the test recent tests I added. --- frontend_tests/node_tests/topic_list.js | 88 ------------------------- 1 file changed, 88 deletions(-) diff --git a/frontend_tests/node_tests/topic_list.js b/frontend_tests/node_tests/topic_list.js index 444d1db283..96ae17107b 100644 --- a/frontend_tests/node_tests/topic_list.js +++ b/frontend_tests/node_tests/topic_list.js @@ -1,10 +1,6 @@ -set_global('$', global.make_zjquery()); -set_global('i18n', global.stub_i18n); - set_global('narrow_state', {}); set_global('unread', {}); set_global('muting', {}); -set_global('stream_popover', {}); set_global('message_list', {}); zrequire('hash_util'); @@ -13,23 +9,16 @@ zrequire('unread'); zrequire('topic_data'); zrequire('topic_list'); -const devel = { - stream_id: 555, - name: 'devel', -}; - const general = { stream_id: 556, name: 'general', }; -stream_data.add_sub('devel', devel); stream_data.add_sub('general', general); function clear() { narrow_state.topic = () => undefined; topic_data.reset(); - stream_popover.hide_topic_popover = function () {}; muting.is_topic_muted = () => false; } @@ -170,80 +159,3 @@ run_test('get_list_info unreads', () => { 'topic 8', ]); }); - -run_test('topic_list_build_widget', () => { - clear(); - - topic_data.get_recent_names = () => { - return ['coding']; - }; - - narrow_state.topic = function () { - return 'testing'; - }; - - unread.num_unread_for_topic = function () { - return 3; - }; - - let checked_mutes; - let rendered; - - global.stub_templates(function (name, info) { - assert.equal(name, 'topic_list_item'); - const expected = { - topic_name: 'coding', - unread: 3, - is_zero: false, - is_muted: false, - is_active_topic: false, - url: '#narrow/stream/555-devel/topic/coding', - }; - assert.deepEqual(info, expected); - rendered = true; - return ''; - }); - - muting.is_topic_muted = function (stream_id, topic_name) { - assert.equal(stream_id, devel.stream_id); - assert.equal(topic_name, 'coding'); - checked_mutes = true; - return false; - }; - - const ul = $('