paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings-users: Rerender bot rows on data change.

Browse Source 
Previously, we fiddled with the existing HTML to update the
state. Now, we can use list_render.render_item() to render
the complete item properly.
This commit is contained in:
Rohitt Vashishtha
2020-05-20 04:02:34 +05:30
committed by Steve Howell
parent a114b6a1b1
commit 58b612a4f0
3 changed files with 13 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
static/js/settings_users.js
View File

@@ -236,16 +236,19 @@ function human_info(person) {
return info;
}
let bot_list_widget;
section.bots.create_table = () => {
loading.make_indicator($('#admin_page_bots_loading_indicator'), {text: 'Loading...'});
const $bots_table = $("#admin_bots_table");
$bots_table.hide();
const bot_user_ids = bot_data.all_user_ids();
list_render.create($bots_table, bot_user_ids, {
bot_list_widget = list_render.create($bots_table, bot_user_ids, {
name: "admin_bot_list",
get_item: bot_info,
modifier: render_admin_user_list,
html_selector: (item) => `tr[data-user-id='${item}']`,
filter: {
element: $bots_table.closest(".settings-section").find(".search"),
predicate: function (item, value) {
@@ -320,6 +323,10 @@ section.deactivated.create_table = (deactivated_users) => {
$("#admin_deactivated_users_table").show();
};
exports.update_bot_data = function (bot_user_id) {
bot_list_widget.render_item(bot_user_id);
};
exports.update_user_data = function (user_id, new_data) {
const user_row = get_user_info_row(user_id);
@@ -332,16 +339,6 @@ exports.update_user_data = function (user_id, new_data) {
user_row.find(".user_name").text(new_data.full_name);
}
if (new_data.owner_id !== undefined) {
// TODO: Linkify the owner name to match the
// formatting of the list. Ideally we can
// make this whole function simpler
// by re-rendering the entire row via
// the list widget.
const owner_name = bot_owner_full_name(new_data.owner_id);
user_row.find(".owner").text(owner_name);
}
if (new_data.is_active !== undefined) {
if (new_data.is_active === false) {
// Deactivate the user/bot in the table