paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Remove subscribers from stream_data subs.

Browse Source 
This sets us up to use better system-wide data structures
for tracking subscribers.

Basically, instead of storing subscriber data on the
"sub" objects in stream_data.js, we instead have a
parallel data structure called stream_subscribers.

We also have stream_create, stream_edit, and friends
use helper functions rather than accessing
sub.subscribers directly.
This commit is contained in:
Steve Howell
2021-01-12 15:05:24 +00:00
committed by Tim Abbott
parent a175ce65cf
commit 58dcc70a35
13 changed files with 243 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
static/js/stream_ui_updates.js
View File

@@ -194,7 +194,8 @@ exports.update_subscribers_list = function (sub) {
if (!sub.can_access_subscribers) {
$(".subscriber_list_settings_container").hide();
} else {
const users = stream_edit.get_users_from_subscribers(sub.subscribers);
const subscribers = stream_data.get_subscribers(sub.stream_id);
const users = stream_edit.get_users_from_subscribers(subscribers);
/*
We try to find a subscribers list that is already in the