paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

edit_history: Remove LEGACY_PREV_TOPIC constant from code base.

Browse Source 
Removes `LEGACY_PREV_TOPIC` which is no longer needed due to the
message edit history migration.

Also remove additions to the linter exclude list that were added
earlier in this commit series.
This commit is contained in:
Lauryn Menard
2022-03-03 17:21:05 +01:00
committed by Tim Abbott
parent e54dfda0b1
commit 58f21fc748
2 changed files with 1 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tools/linter_lib/custom_check.py
View File

@@ -12,10 +12,7 @@ from zulint.custom_rules import Rule, RuleList
FILES_WITH_LEGACY_SUBJECT = {
# This basically requires a big DB migration:
"zerver/lib/message.py",
"zerver/lib/topic.py",
"zerver/lib/types.py",
"zerver/views/message_edit.py",
# This is for backward compatibility.
"zerver/tests/test_legacy_subject.py",
# Other migration-related changes require extreme care.
@@ -232,7 +229,7 @@ python_rules = RuleList(
rules=[
{
"pattern": "subject|SUBJECT",
"exclude_pattern": "subject to the|email|outbox|edit_history_event",
"exclude_pattern": "subject to the|email|outbox",
"description": "avoid subject as a var",
"good_lines": ["topic_name"],
"bad_lines": ['subject="foo"', " MAX_SUBJECT_LEN"],