paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-19 22:19:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

left_sidebar: Rename private_messages_section_header to use direct.

Browse Source 
Rename `private_messages_section_header` to
`direct-messages-section-header`.
We've also hyphenated the attribute during the rename.
Part of the private_message to direct_message rename project.
This commit is contained in:
Shubham Padia
2024-06-07 03:14:50 +00:00
committed by Tim Abbott
parent b197659d8a
commit 5a3fc26d74
5 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/click_handlers.js
View File

@@ -779,7 +779,7 @@ export function initialize() {
$("body").on( $("body").on(
"click", "click",
".direct-messages-container.zoom-out #private_messages_section_header", ".direct-messages-container.zoom-out #direct-messages-section-header",
(e) => { (e) => {
if ($(e.target).closest("#show_all_private_messages").length === 1) { if ($(e.target).closest("#show_all_private_messages").length === 1) {
// Let the browser handle the "direct message feed" widget. // Let the browser handle the "direct message feed" widget.
@@ -813,7 +813,7 @@ export function initialize() {
* this click handler rather than just a link. */ * this click handler rather than just a link. */
$("body").on( $("body").on(
"click", "click",
".direct-messages-container.zoom-in #private_messages_section_header", ".direct-messages-container.zoom-in #direct-messages-section-header",
(e) => { (e) => {
e.preventDefault(); e.preventDefault();
e.stopPropagation(); e.stopPropagation();

6
web/src/pm_list.ts
View File

@@ -23,9 +23,7 @@ let private_messages_collapsed = false;
let zoomed = false; let zoomed = false;
function get_private_messages_section_header(): JQuery { function get_private_messages_section_header(): JQuery {
return $( return $(".direct-messages-container #direct-messages-section #direct-messages-section-header");
".direct-messages-container #direct-messages-section #private_messages_section_header",
);
} }
export function set_count(count: number): void { export function set_count(count: number): void {
@@ -130,7 +128,7 @@ function unhighlight_all_private_messages_view(): void {
function scroll_pm_into_view($target_li: JQuery): void { function scroll_pm_into_view($target_li: JQuery): void {
const $container = $("#left_sidebar_scroll_container"); const $container = $("#left_sidebar_scroll_container");
const pm_header_height = $("#private_messages_section_header").outerHeight(); const pm_header_height = $("#direct-messages-section-header").outerHeight();
if ($target_li.length > 0) { if ($target_li.length > 0) {
scroll_util.scroll_element_into_container($target_li, $container, pm_header_height); scroll_util.scroll_element_into_container($target_li, $container, pm_header_height);
} }

4
web/styles/left_sidebar.css
View File

@@ -219,7 +219,7 @@ li.show-more-topics {
in the DM section. */ in the DM section. */
margin-right: 12px; margin-right: 12px;
#private_messages_section_header { #direct-messages-section-header {
grid-template-columns: 0 15px minmax(0, 1fr) max-content 30px 0; grid-template-columns: 0 15px minmax(0, 1fr) max-content 30px 0;
grid-template-rows: var(--line-height-sidebar-row-prominent); grid-template-rows: var(--line-height-sidebar-row-prominent);
/* TODO: Rewrite the `--left-sidebar-collapse-widget-gutter` /* TODO: Rewrite the `--left-sidebar-collapse-widget-gutter`
@@ -748,7 +748,7 @@ li.top_left_scheduled_messages {
grid-template-areas: "starting-offset starting-anchor-element row-content markers-and-controls ending-anchor-element ending-offset"; grid-template-areas: "starting-offset starting-anchor-element row-content markers-and-controls ending-anchor-element ending-offset";
} }
#private_messages_section_header, #direct-messages-section-header,
#streams_header, #streams_header,
#topics_header { #topics_header {
display: grid; display: grid;

2
web/templates/left_sidebar.hbs
View File

@@ -145,7 +145,7 @@
<div id="direct-messages-sticky-header" class="direct-messages-container zoom-out hidden-for-spectators"> <div id="direct-messages-sticky-header" class="direct-messages-container zoom-out hidden-for-spectators">
<div id="direct-messages-section"> <div id="direct-messages-section">
<div id="private_messages_section_header" class="zoom-out zoom-in-sticky"> <div id="direct-messages-section-header" class="zoom-out zoom-in-sticky">
<i id="toggle_private_messages_section_icon" class="fa fa-sm fa-caret-down dm-tooltip-target toggle_private_messages_section zoom-in-hide" aria-hidden="true" tabindex="0" role="button"></i> <i id="toggle_private_messages_section_icon" class="fa fa-sm fa-caret-down dm-tooltip-target toggle_private_messages_section zoom-in-hide" aria-hidden="true" tabindex="0" role="button"></i>
<h4 class="left-sidebar-title toggle_private_messages_section"><span class="dm-tooltip-target">{{t 'DIRECT MESSAGES' }}</span></h4> <h4 class="left-sidebar-title toggle_private_messages_section"><span class="dm-tooltip-target">{{t 'DIRECT MESSAGES' }}</span></h4>
<div class="heading-markers-and-controls"> <div class="heading-markers-and-controls">

2
web/tests/pm_list.test.js
View File

@@ -13,7 +13,7 @@ run_test("update_dom_with_unread_counts", () => {
const $total_count = $.create("total-count-stub"); const $total_count = $.create("total-count-stub");
const $private_li = $( const $private_li = $(
".direct-messages-container #direct-messages-section #private_messages_section_header", ".direct-messages-container #direct-messages-section #direct-messages-section-header",
); );
$private_li.set_find_results(".unread_count", $total_count); $private_li.set_find_results(".unread_count", $total_count);