js: Convert static/js/settings_toggle.js to ES6 module.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

.eslintrc.json

@@ -197,7 +197,6 @@
                 "settings_profile_fields": false,
                 "settings_sections": false,
                 "settings_streams": false,
-                "settings_toggle": false,
                 "settings_user_groups": false,
                 "settings_users": false,
                 "starred_messages": false,

frontend_tests/node_tests/ui_init.js

@@ -90,7 +90,7 @@ set_global("scroll_bar", {initialize() {}});
 const server_events = set_global("server_events", {initialize() {}});
 set_global("settings_sections", {initialize() {}});
 rewiremock("../../static/js/settings_panel_menu").with({initialize() {}});
-set_global("settings_toggle", {initialize() {}});
+rewiremock("../../static/js/settings_toggle").with({initialize() {}});
 set_global("subs", {initialize() {}});
 set_global("timerender", {initialize() {}});
 const ui = set_global("ui", {initialize() {}});

static/js/admin.js

@@ -6,6 +6,7 @@ const render_settings_organization_settings_tip = require("../templates/settings
 const settings_config = require("./settings_config");
 const settings_data = require("./settings_data");
 const settings_panel_menu = require("./settings_panel_menu");
+const settings_toggle = require("./settings_toggle");
 
 const admin_settings_label = {
     // Organization settings

static/js/bundles/app.js

@@ -27,7 +27,6 @@ import "../reload";
 import "../compose_actions";
 import "../subs";
 import "../ui";
-import "../settings_toggle";
 import "../scroll_bar";
 import "../gear_menu";
 import "../stream_popover";

static/js/click_handlers.js

@@ -14,6 +14,7 @@ import * as message_edit_history from "./message_edit_history";
 import * as muting_ui from "./muting_ui";
 import * as rows from "./rows";
 import * as settings_panel_menu from "./settings_panel_menu";
+import * as settings_toggle from "./settings_toggle";
 import * as stream_edit from "./stream_edit";
 import * as ui_util from "./ui_util";
 import * as user_status_ui from "./user_status_ui";

static/js/global.d.ts

@@ -70,7 +70,6 @@ declare let settings_org: any;
 declare let settings_profile_fields: any;
 declare let settings_sections: any;
 declare let settings_streams: any;
-declare let settings_toggle: any;
 declare let settings_user_groups: any;
 declare let settings_users: any;
 declare let starred_messages: any;

static/js/settings.js

@@ -6,6 +6,7 @@ const render_settings_tab = require("../templates/settings_tab.hbs");
 const people = require("./people");
 const settings_config = require("./settings_config");
 const settings_panel_menu = require("./settings_panel_menu");
+const settings_toggle = require("./settings_toggle");
 
 $("body").ready(() => {
     $("#settings_overlay_container").on("click", (e) => {

static/js/settings_toggle.js

@@ -1,17 +1,15 @@
-"use strict";
+import * as components from "./components";
-
+import * as settings_panel_menu from "./settings_panel_menu";
-const components = require("./components");
-const settings_panel_menu = require("./settings_panel_menu");
 
 let toggler;
 
-exports.highlight_toggle = function (tab_name) {
+export function highlight_toggle(tab_name) {
     if (toggler) {
         toggler.goto(tab_name);
     }
-};
+}
 
-exports.initialize = function () {
+export function initialize() {
     toggler = components.toggle({
         child_wants_focus: true,
         values: [
@@ -30,10 +28,10 @@ exports.initialize = function () {
     settings_panel_menu.set_key_handlers(toggler);
 
     $("#settings_overlay_container .tab-container").append(toggler.get());
-};
+}
 
 // Handles the collapse/reveal of some tabs in the org settings for non-admins.
-exports.toggle_org_setting_collapse = function () {
+export function toggle_org_setting_collapse() {
     const is_collapsed = $(".collapse-org-settings").hasClass("hide-org-settings");
     const show_fewer_settings_text = i18n.t("Show fewer");
     const show_more_settings_text = i18n.t("Show more");
@@ -63,6 +61,4 @@ exports.toggle_org_setting_collapse = function () {
     if (current_tab.hasClass("hide-org-settings")) {
         $(location).attr("href", "/#organization/organization-profile");
     }
-};
+}
-
-window.settings_toggle = exports;

static/js/ui_init.js

@@ -33,6 +33,7 @@ const resize = require("./resize");
 const rows = require("./rows");
 const sent_messages = require("./sent_messages");
 const settings_panel_menu = require("./settings_panel_menu");
+const settings_toggle = require("./settings_toggle");
 const spoilers = require("./spoilers");
 const stream_color = require("./stream_color");
 const stream_data = require("./stream_data");