paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

search_suggestion: Don't show operator suggestion if its incompatible.

Browse Source 
Earlier, we would show operator suggestion even if it is incompatible
with current search terms. Selecting this wouldn't show further
suggestions for the operator since we don't allow narrow to incompatible
search terms.

This commit fixes this by hiding new suggestions if it is not
compatible with current search terms in the search box.
This commit is contained in:
Pratik Chanda
2025-07-29 19:59:53 +05:30
committed by Tim Abbott
parent 35bfc8bace
commit 5c16549b8a
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
web/src/search_suggestion.ts
View File

@@ -799,7 +799,7 @@ function get_sent_by_me_suggestions(last: NarrowTerm, terms: NarrowTerm[]): Sugg
return [];
}
function get_operator_suggestions(last: NarrowTerm): Suggestion[] {
function get_operator_suggestions(last: NarrowTerm, terms: NarrowTerm[]): Suggestion[] {
if (!(last.operator === "search" || last.operator === "")) {
return [];
}
@@ -831,7 +831,14 @@ function get_operator_suggestions(last: NarrowTerm): Suggestion[] {
];
}
choices = choices.filter((choice) => common.phrase_match(last_operand, choice));
// We remove suggestion choice if its incompatible_pattern matches
// that of current search terms.
choices = choices.filter(
(choice) =>
common.phrase_match(last_operand, choice) &&
(!incompatible_patterns[choice] ||
!match_criteria(terms, incompatible_patterns[choice])),
);
return choices.map((choice) => {
// Map results for "dm:" operator for users