paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Fix accidental uses of assert() -> assert.equal().

Browse Source
This commit is contained in:
Rohitt Vashishtha
2019-02-15 22:38:59 +00:00
committed by Tim Abbott
parent 92658d2ac9
commit 5c2e64d6a2
7 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
frontend_tests/node_tests/activity.js
View File

@@ -178,7 +178,7 @@ run_test('get_status', () => {
run_test('reload_defaults', () => {
blueslip.set_test_data('warn', 'get_filter_text() is called before initialization');
assert.equal(activity.get_filter_text(), '');
assert(blueslip.get_test_logs('warn').length, 1);
assert.equal(blueslip.get_test_logs('warn').length, 1);
blueslip.clear_test_data();
});
@@ -816,8 +816,8 @@ run_test('update_presence_info', () => {
blueslip.set_test_data('warn', 'unknown email: foo@bar.com');
blueslip.set_test_data('error', 'Unknown email for get_user_id: foo@bar.com');
activity.update_presence_info('foo@bar.com', info, server_time);
assert(blueslip.get_test_logs('warn').length, 1);
assert(blueslip.get_test_logs('error').length, 1);
assert.equal(blueslip.get_test_logs('warn').length, 1);
assert.equal(blueslip.get_test_logs('error').length, 1);
blueslip.clear_test_data();
});

4
frontend_tests/node_tests/markdown.js
View File

@@ -530,7 +530,7 @@ run_test('python_to_js_filter', () => {
actual_value = marked.InlineLexer.rules.zulip.realm_filters;
expected_value = [];
assert.deepEqual(actual_value, expected_value);
assert(blueslip.get_test_logs('error').length, 1);
assert.equal(blueslip.get_test_logs('error').length, 1);
blueslip.clear_test_data();
});
@@ -539,7 +539,7 @@ run_test('katex_throws_unexpected_exceptions', () => {
blueslip.set_test_data('error', 'Error: some-exception');
var message = { raw_content: '$$a$$' };
markdown.apply_markdown(message);
assert(blueslip.get_test_logs('error').length, 1);
assert.equal(blueslip.get_test_logs('error').length, 1);
blueslip.clear_test_data();
});

2
frontend_tests/node_tests/people.js
View File

@@ -833,7 +833,7 @@ run_test('initialize', () => {
assert(people.is_my_user_id(42));
var fetched_retiree = people.get_person_from_user_id(15);
assert(fetched_retiree.full_name, 'Retiree');
assert.equal(fetched_retiree.full_name, 'Retiree');
assert.equal(global.page_params.realm_users, undefined);
assert.equal(global.page_params.cross_realm_bots, undefined);

2
frontend_tests/node_tests/search_pill.js
View File

@@ -73,5 +73,5 @@ run_test('create_pills', () => {
var pills = search_pill.create_pills({});
assert(input_pill_create_called);
assert(pills, {dummy: 'dummy'});
assert.deepEqual(pills, {dummy: 'dummy'});
});

2
frontend_tests/node_tests/settings_user_groups.js
View File

@@ -302,7 +302,7 @@ run_test('populate_user_groups', () => {
assert(user_groups_list_append_called);
assert(get_person_from_user_id_called);
assert(input_typeahead_called);
assert(blueslip.get_test_logs('warn').length, 1);
assert.equal(blueslip.get_test_logs('warn').length, 1);
blueslip.clear_test_data();
test_create_item(create_item_handler);

6
frontend_tests/node_tests/user_groups.js
View File

@@ -50,14 +50,14 @@ run_test('user_groups', () => {
blueslip.set_test_data('error', 'Unknown group_id in get_user_group_from_id: ' + all.id);
assert.equal(user_groups.get_user_group_from_id(all.id), undefined);
assert(blueslip.get_test_logs('error').length, 1);
assert.equal(blueslip.get_test_logs('error').length, 1);
blueslip.clear_test_data();
user_groups.remove(students);
blueslip.set_test_data('error', 'Unknown group_id in get_user_group_from_id: ' + students.id);
assert.equal(user_groups.get_user_group_from_id(students.id), undefined);
assert(blueslip.get_test_logs('error').length, 1);
assert.equal(blueslip.get_test_logs('error').length, 1);
blueslip.clear_test_data();
assert.equal(user_groups.get_user_group_from_name(all.name), undefined);
@@ -92,6 +92,6 @@ run_test('user_groups', () => {
blueslip.set_test_data('error', 'Could not find user group with ID -1');
assert.equal(user_groups.is_member_of(-1, 15), false);
assert(blueslip.get_test_logs('error').length, 1);
assert.equal(blueslip.get_test_logs('error').length, 1);
blueslip.clear_test_data();
});

2
frontend_tests/node_tests/util.js
View File

@@ -110,7 +110,7 @@ run_test('robust_uri_decode', () => {
try {
util.robust_uri_decode('%E0%A4%A');
} catch (e) {
assert(e, 'foo');
assert.equal(e, 'foo');
}
});