paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 18:36:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

buddy_list: Refactor render code for readability.

Browse Source
This commit is contained in:
evykassirer
2024-09-18 11:19:10 -07:00
committed by Tim Abbott
parent cd5a61eb52
commit 5c6e3a7aac
2 changed files with 26 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
web/src/buddy_list.ts
View File

@@ -449,31 +449,29 @@ export class BuddyList extends BuddyListConf {
}
}
// Remove the empty list message before adding users
if (
$(`${this.matching_view_list_selector} .empty-list-message`).length > 0 &&
subscribed_users.length
) {
this.$users_matching_view_list.empty();
}
const subscribed_users_html = this.items_to_html({
items: subscribed_users,
});
this.$users_matching_view_list = $(this.matching_view_list_selector);
this.$users_matching_view_list.append($(subscribed_users_html));
// Remove the empty list message before adding users
if (
$(`${this.other_user_list_selector} .empty-list-message`).length > 0 &&
other_users.length
) {
this.$other_users_list.empty();
if (subscribed_users.length) {
// Remove the empty list message before adding users
if ($(`${this.matching_view_list_selector} .empty-list-message`).length > 0) {
this.$users_matching_view_list.empty();
}
const subscribed_users_html = this.items_to_html({
items: subscribed_users,
});
this.$users_matching_view_list.append($(subscribed_users_html));
}
const other_users_html = this.items_to_html({
items: other_users,
});
this.$other_users_list = $(this.other_user_list_selector);
this.$other_users_list.append($(other_users_html));
if (other_users.length) {
// Remove the empty list message before adding users
if ($(`${this.other_user_list_selector} .empty-list-message`).length > 0) {
this.$other_users_list.empty();
}
const other_users_html = this.items_to_html({
items: other_users,
});
this.$other_users_list.append($(other_users_html));
}
// Invariant: more_user_ids.length >= items.length.
// (Usually they're the same, but occasionally user ids