paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 18:06:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

buddy_list: Show offline subscribed users for small channels in big orgs.

Browse Source 
Previously, for big orgs, we hid all offline users in the buddy list to cut down
its size. But this can be weird for small channels where you might want to see
who's in the channel. This commit makes a tweak to show offline users in big
orgs for channels of size <= 50.
This commit is contained in:
evykassirer
2024-09-18 12:45:52 -07:00
committed by Tim Abbott
parent 9dd8de64a9
commit 5ddcbb8516
2 changed files with 58 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
web/src/buddy_data.ts
View File

@@ -5,6 +5,7 @@ import {$t} from "./i18n";
import * as muted_users from "./muted_users";
import * as narrow_state from "./narrow_state";
import {page_params} from "./page_params";
import * as peer_data from "./peer_data";
import * as people from "./people";
import * as presence from "./presence";
import {realm} from "./state_data";
@@ -26,6 +27,7 @@ import * as util from "./util";
*/
export const max_size_before_shrinking = 600;
export const max_channel_size_to_show_all_subscribers = 75;
let is_searching_users = false;
@@ -300,8 +302,15 @@ function maybe_shrink_list(user_ids: number[], user_filter_text: string): number
// We want to always show PM recipients even if they're inactive.
const pm_ids_set = narrow_state.pm_ids_set();
const stream_id = narrow_state.stream_id();
const filter_by_stream_id =
stream_id &&
peer_data.get_subscriber_count(stream_id) <= max_channel_size_to_show_all_subscribers;
user_ids = user_ids.filter(
(user_id) => user_is_recently_active(user_id) || user_matches_narrow(user_id, pm_ids_set),
(user_id) =>
user_is_recently_active(user_id) ||
user_matches_narrow(user_id, pm_ids_set, filter_by_stream_id ? stream_id : undefined),
);
return user_ids;