paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

js: Rename viewport.js to message_viewport.js.

Browse Source 
This fixes the mobile web experience for Chrome on iOS.

Apparently, Chrome-on-iOS silently has a `viewport` module that
overrides and user-defined module by that name, causing all of our
code that accesses the viewport module to not work on that platform.
We fix this by renaming it.
This commit is contained in:
Tim Abbott
2017-03-10 14:48:51 -08:00
parent b1f12133be
commit 5e39ccd642
21 changed files with 67 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
static/js/message_edit.js
View File

@@ -283,7 +283,7 @@ function edit_message(row, raw_content) {
var edit_top = message_edit_content[0].getBoundingClientRect().top;
var scroll_by = edit_top - content_top + 5 /* border and padding */;
edit_obj.scrolled_by = scroll_by;
viewport.scrollTop(viewport.scrollTop() + scroll_by);
message_viewport.scrollTop(message_viewport.scrollTop() + scroll_by);
if (feature_flags.propagate_topic_edits && message.local_id === undefined) {
var original_topic = message.subject;
@@ -299,7 +299,7 @@ function start_edit_maintaining_scroll(row, content) {
var row_bottom = row.height() + row.offset().top;
var composebox_top = $("#compose").offset().top;
if (row_bottom > composebox_top) {
viewport.scrollTop(viewport.scrollTop() + row_bottom - composebox_top);
message_viewport.scrollTop(message_viewport.scrollTop() + row_bottom - composebox_top);
}
}
@@ -347,7 +347,7 @@ exports.end = function (row) {
if (message !== undefined &&
currently_editing_messages[message.id] !== undefined) {
var scroll_by = currently_editing_messages[message.id].scrolled_by;
viewport.scrollTop(viewport.scrollTop() - scroll_by);
message_viewport.scrollTop(message_viewport.scrollTop() - scroll_by);
delete currently_editing_messages[message.id];
current_msg_list.hide_edit_message(row);
}