paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

bot_data: Fix owner_id field to allow null value.

Browse Source 
According to zulip `/register` API doc, `realm_bots[].owner_id`
should be nullable.
Fixes commit 7140149373.
This commit is contained in:
Junyao Chen
2023-08-21 21:53:15 -04:00
committed by Tim Abbott
parent 328cdde243
commit 5efe78205d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/bot_data.ts
View File

@@ -26,7 +26,7 @@ const basic_bot_schema = z.object({
email: z.string(), email: z.string(),
full_name: z.string(), full_name: z.string(),
is_active: z.boolean(), is_active: z.boolean(),
owner_id: z.number(), owner_id: z.number().nullable(),
user_id: z.number(), user_id: z.number(),
}); });
@@ -90,7 +90,7 @@ export function update(bot_id: number, bot_update: ServerUpdateBotData): void {
export function get_all_bots_for_current_user(): Bot[] { export function get_all_bots_for_current_user(): Bot[] {
const ret = []; const ret = [];
for (const bot of bots.values()) { for (const bot of bots.values()) {
if (people.is_my_user_id(bot.owner_id)) { if (bot.owner_id !== null && people.is_my_user_id(bot.owner_id)) {
ret.push(bot); ret.push(bot);
} }
} }
@@ -100,7 +100,7 @@ export function get_all_bots_for_current_user(): Bot[] {
export function get_editable(): Bot[] { export function get_editable(): Bot[] {
const ret = []; const ret = [];
for (const bot of bots.values()) { for (const bot of bots.values()) {
if (bot.is_active && people.is_my_user_id(bot.owner_id)) { if (bot.is_active && bot.owner_id !== null && people.is_my_user_id(bot.owner_id)) {
ret.push(bot); ret.push(bot);
} }
} }