paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Enforce 100% URL coverage.

Browse Source 
We now instrument URL coverage whenever you run the back end tests,
and if you run the full suite and fail to test all endpoints, we
exit with a non-zero exit code and report failures to you.

If you are running just a subset of the test suite, you'll still
be able to see var/url_coverage.txt, which has some useful info.

With some tweaks to the output from tabbott.

Fixes #1441.
This commit is contained in:
Steve Howell
2016-11-18 16:28:28 -08:00
committed by Tim Abbott
parent d8dee522b6
commit 5f5e6b6d83
3 changed files with 24 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
zerver/lib/test_helpers.py
View File

@@ -47,6 +47,7 @@ import base64
import mock
import os
import re
import sys
import time
import ujson
import unittest
@@ -249,8 +250,8 @@ def instrument_url(f):
return result
return wrapper
def write_instrumentation_reports():
# type: () -> None
def write_instrumentation_reports(full_suite):
# type: (bool) -> None
if INSTRUMENTING:
calls = INSTRUMENTED_CALLS
var_dir = 'var' # TODO make sure path is robust here
@@ -270,8 +271,9 @@ def write_instrumentation_reports():
''')
print(call)
print('URL coverage report is in %s' % (fn,))
print('Try running: ./tools/analyze-url-coverage')
if full_suite:
print('URL coverage report is in %s' % (fn,))
print('Try running: ./tools/analyze-url-coverage')
# Find our untested urls.
from zproject.urls import urlpatterns
@@ -286,12 +288,12 @@ def write_instrumentation_reports():
else:
untested_patterns.append(pattern.regex.pattern)
fn = os.path.join(var_dir, 'untested_url_report.txt')
with open(fn, 'w') as f:
f.write('untested urls\n')
if full_suite and len(untested_patterns):
print("\nERROR: Some URLs are untested! Here's the list of untested URLs:")
for untested_pattern in sorted(untested_patterns):
f.write(' %s\n' % (untested_pattern,))
print('Untested-url report is in %s' % (fn,))
print(" %s" % (untested_pattern,))
sys.exit(1)
def get_all_templates():
# type: () -> List[str]