paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

upload widget: Rename image upload widget upload text CSS class.

Browse Source 
Previously, image upload widget delete text CSS class name was
`settings-page-upload-text`.
We can change the CSS class name to `image-upload-text`
so that the name can be more generic.
This commit is contained in:
jagansivam28
2020-07-16 00:50:36 +05:30
committed by Tim Abbott
parent ad0ff10598
commit 5f874a51f7
4 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/settings_account.js
View File

@@ -77,14 +77,14 @@ exports.update_avatar_change_display = function () {
function display_avatar_upload_complete() { function display_avatar_upload_complete() {
$("#user-avatar-upload-widget .upload-spinner-background").css({visibility: "hidden"}); $("#user-avatar-upload-widget .upload-spinner-background").css({visibility: "hidden"});
$("#user-avatar-upload-widget .settings-page-upload-text").show(); $("#user-avatar-upload-widget .image-upload-text").show();
$("#user-avatar-upload-widget .image-delete-button").show(); $("#user-avatar-upload-widget .image-delete-button").show();
} }
function display_avatar_upload_started() { function display_avatar_upload_started() {
$("#user-avatar-source").hide(); $("#user-avatar-source").hide();
$("#user-avatar-upload-widget .upload-spinner-background").css({visibility: "visible"}); $("#user-avatar-upload-widget .upload-spinner-background").css({visibility: "visible"});
$("#user-avatar-upload-widget .settings-page-upload-text").hide(); $("#user-avatar-upload-widget .image-upload-text").hide();
$("#user-avatar-upload-widget .image-delete-button").hide(); $("#user-avatar-upload-widget .image-delete-button").hide();
} }

2
static/js/settings_org.js
View File

@@ -1046,7 +1046,7 @@ exports.build_page = function () {
form_data.append("night", JSON.stringify(night)); form_data.append("night", JSON.stringify(night));
} }
const spinner = $(`${widget} .upload-spinner-background`).expectOne(); const spinner = $(`${widget} .upload-spinner-background`).expectOne();
const upload_text = $(`${widget} .settings-page-upload-text`).expectOne(); const upload_text = $(`${widget} .image-upload-text`).expectOne();
const delete_button = $(`${widget} .image-delete-button`).expectOne(); const delete_button = $(`${widget} .image-delete-button`).expectOne();
const error_field = $(`${widget} .image_file_input_error`).expectOne(); const error_field = $(`${widget} .image_file_input_error`).expectOne();
realm_icon_logo_upload_start(spinner, upload_text, delete_button); realm_icon_logo_upload_start(spinner, upload_text, delete_button);

14
static/styles/image_upload_widget.scss
View File

@@ -39,7 +39,7 @@
color: hsl(0, 0%, 100%); color: hsl(0, 0%, 100%);
} }
.image-delete-button:hover ~ .settings-page-upload-text { .image-delete-button:hover ~ .image-upload-text {
visibility: hidden; visibility: hidden;
} }
@@ -55,7 +55,7 @@
z-index: 99; z-index: 99;
} }
.settings-page-upload-text { .image-upload-text {
cursor: pointer; cursor: pointer;
font-size: 0.85rem; font-size: 0.85rem;
color: hsl(0, 0%, 85%); color: hsl(0, 0%, 85%);
@@ -64,7 +64,7 @@
visibility: hidden; visibility: hidden;
} }
.settings-page-upload-text:hover { .image-upload-text:hover {
color: hsl(0, 0%, 100%); color: hsl(0, 0%, 100%);
} }
@@ -91,7 +91,7 @@
opacity: 1; opacity: 1;
} }
.settings-page-upload-text { .image-upload-text {
visibility: visible; visibility: visible;
} }
@@ -131,7 +131,7 @@
right: 40px; right: 40px;
} }
.settings-page-upload-text { .image-upload-text {
top: 90px; top: 90px;
right: 20px; right: 20px;
} }
@@ -173,7 +173,7 @@
right: 18px; right: 18px;
} }
.settings-page-upload-text { .image-upload-text {
top: 40px; top: 40px;
right: 18px; right: 18px;
} }
@@ -200,7 +200,7 @@
text-align: center; text-align: center;
margin: 0px 80px 0px 20px; margin: 0px 80px 0px 20px;
.settings-page-upload-text, .image-upload-text,
.image-delete-text { .image-delete-text {
top: 17px; top: 17px;
right: 80px; right: 80px;

2
static/templates/settings/image_upload_widget.hbs
View File

@@ -8,7 +8,7 @@
<span class="image-delete-text" aria-label="{{ delete_text }}" tabindex="0"> <span class="image-delete-text" aria-label="{{ delete_text }}" tabindex="0">
{{ delete_text }} {{ delete_text }}
</span> </span>
<span class="settings-page-upload-text" aria-label="{{ upload_text }}" role="button" tabindex="0"> <span class="image-upload-text" aria-label="{{ upload_text }}" role="button" tabindex="0">
{{ upload_text }} {{ upload_text }}
</span> </span>
<span class="upload-spinner-background"> <span class="upload-spinner-background">