paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 20:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Warn if server is unable to deliver mobile push notifications.

Browse Source 
The "notification settings" page previously advertised support for
mobile push notifications via checkboxes, even if the server hadn't
yet been registered for push notifications.  This was a frequent
source of onboarding pain for new Zulip organizations.

We fix this by providing a clear warning and disabling the relevant
inputs on the settings pages.

Modified significantly by tabbott to correct some tricky logic errors
as well as some copy-paste bugs.

Fixes #10331.
This commit is contained in:
Shikhar Vaish
2018-08-31 02:15:59 +05:30
committed by Tim Abbott
parent f5c3a4aea7
commit 5ffca5e388
4 changed files with 35 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
frontend_tests/node_tests/templates.js
View File

@@ -1075,6 +1075,7 @@ run_test('settings_tab', () => {
enable_offline_push_notifications: true, enable_online_push_notifications: true,
enable_digest_emails: true,
realm_name_in_notifications: true,
realm_push_notifications_enabled: true,
};
var page_params = $.extend(page_param_checkbox_options, {
full_name: "Alyssa P. Hacker", password_auth_enabled: true,