paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 06:23:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Restructure 'Personal settings > Notifications' section.

Browse Source 
We remove the 'Other notification settings' heading and increase the
font size of 'Desktop message notifications' and 'Mobile message
notifications' headings as these are now on the same level with
'Notification triggers' heading.

We also add status elements to show saving indicator along the mobile,
desktop and email headings which was previously shown with the
"Other notification settings" heading.
This commit is contained in:
Sahil Batra
2021-09-11 13:23:38 +05:30
committed by Tim Abbott
parent 14e383ad7a
commit 60112405ba
1 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
static/templates/settings/notification_settings.hbs
View File

@@ -44,12 +44,10 @@
</table> </table>
</div> </div>
<div class="other_notifications m-10 inline-block subsection-parent"> <div class="desktop_notifications m-10 inline-block subsection-parent">
<h3 class="inline-block">{{t "Other notification settings" }}</h3> <h3 class="inline-block">{{t "Desktop message notifications" }}</h3>
<div class="alert-notification other-notify-settings-status"></div> <div class="alert-notification"></div>
<h5>{{t "Desktop message notifications" }}</h5>
<p><a class="send_test_notification">{{t "Test desktop notification" }}</a></p> <p><a class="send_test_notification">{{t "Test desktop notification" }}</a></p>
@@ -87,8 +85,12 @@
{{> dropdown_options_widget option_values=desktop_icon_count_display_values}} {{> dropdown_options_widget option_values=desktop_icon_count_display_values}}
</select> </select>
</div> </div>
</div>
<h5>{{t "Mobile message notifications" }}</h5> <div class="mobile_notifications m-10 inline-block subsection-parent">
<h3 class="inline-block">{{t "Mobile message notifications" }}</h3>
<div class="alert-notification"></div>
{{#each notification_settings.mobile_notification_settings}} {{#each notification_settings.mobile_notification_settings}}
{{> settings_checkbox {{> settings_checkbox
@@ -98,8 +100,12 @@
show_push_notifications_tooltip=(lookup ../show_push_notifications_tooltip this) show_push_notifications_tooltip=(lookup ../show_push_notifications_tooltip this)
prefix=../prefix}} prefix=../prefix}}
{{/each}} {{/each}}
</div>
<h5>{{t "Email" }}</h5> <div class="email_notifications m-10 inline-block subsection-parent">
<h3 class="inline-block">{{t "Email" }}</h3>
<div class="alert-notification"></div>
<label for="email_notifications_batching_period"> <label for="email_notifications_batching_period">
{{t "Batching period for email notifications" }} {{t "Batching period for email notifications" }}