paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-20 06:28:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

widgets: Always render and activate widgets in the current view.

Browse Source 
Earlier we did not activate widgets if their rendered HTML was cached,
and also when narrowing to the combined feed view. This caused bugs with
widgets not being activated, and so not responding to any interactions.

Now we unconditionally render and activate widgets in the current view,
irrespective of the cached HTML or the view being narrowed to.
This commit is contained in:
N-Shar-ma
2024-05-07 07:20:04 +05:30
committed by Tim Abbott
parent ebd4468a81
commit 61b3c698af
4 changed files with 14 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
web/tests/widgetize.test.js
View File

@@ -73,7 +73,7 @@ function test(label, f) {
});
}
test("activate", ({override}) => {
test("activate", () => {
// Both widgetize.activate and widgetize.handle_event are tested
// here to use the "caching" of widgets
const $row = $.create("<stub message row>");
@@ -108,7 +108,6 @@ test("activate", ({override}) => {
is_event_handled = false;
assert.ok(!widgetize.widget_contents.has(opts.message.id));
$message_content.set_find_results(".widget-content", false);
widgetize.activate(opts);
assert.ok(is_widget_elem_inserted);
@@ -116,23 +115,11 @@ test("activate", ({override}) => {
assert.ok(is_event_handled);
assert.equal(widgetize.widget_contents.get(opts.message.id), $widget_elem);
is_widget_elem_inserted = false;
is_widget_activated = false;
is_event_handled = false;
$message_content.set_find_results(".widget-content", false);
widgetize.activate(opts);
assert.ok(is_widget_elem_inserted);
assert.ok(!is_widget_activated);
assert.ok(!is_event_handled);
message_lists.current = undefined;
is_widget_elem_inserted = false;
is_widget_activated = false;
is_event_handled = false;
$message_content.set_find_results(".widget-content", false);
widgetize.activate(opts);
assert.ok(!is_widget_elem_inserted);
@@ -179,16 +166,4 @@ test("activate", ({override}) => {
post_activate_event.message_id = 1000;
widgetize.handle_event(post_activate_event);
assert.ok(!is_event_handled);
message_lists.current = {id: 2};
/* Test narrow change message update */
override(message_lists.current, "get", (idx) => {
assert.equal(idx, 2001);
return {};
});
override(message_lists.current, "get_row", (idx) => {
assert.equal(idx, 2001);
return $row;
});
widgetize.set_widgets_for_list();
});