paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 11:52:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

narrow_history: Remove invalid assertion.

Browse Source 
Since non message views list channel topic list can have a defined
filter, we cannot assume that having `narrow_state.filter` set
implies `message_list.current` is defined.
This commit is contained in:
Aman Agrawal
2025-06-20 11:54:38 +05:30
committed by Tim Abbott
parent 93c4dcbdc9
commit 623fa98976
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/narrow_history.ts
View File

@@ -26,12 +26,12 @@ function is_URL_hash_same_as_filter_hash(filter: Filter): boolean {
// history, so that we are able to restore it if the user // history, so that we are able to restore it if the user
// navigates back to this page. // navigates back to this page.
function _save_narrow_state(): void { function _save_narrow_state(): void {
const current_filter = narrow_state.filter(); if (message_lists.current === undefined) {
if (current_filter === undefined) {
return; return;
} }
assert(message_lists.current !== undefined); const current_filter = narrow_state.filter();
assert(current_filter !== undefined);
// Only save state if the URL hash matches the filter terms. // Only save state if the URL hash matches the filter terms.
if (!is_URL_hash_same_as_filter_hash(current_filter)) { if (!is_URL_hash_same_as_filter_hash(current_filter)) {
return; return;