paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

queue_processors: Drop unused current_queue_size, which was local size.

Browse Source 
The `current_queue_size` key in the queue monitoring stats file was
the local queue size, not the global queue size -- d5a6b0f99a
renamed the function, but did not adjust the queue monitoring JSON,
despite the last use of it having been removed in cd9b194d88.

The function is still used to mark "we emptied our queue," and it
remains a reasonable metric for that.
This commit is contained in:
Alex Vandiver
2021-11-15 13:32:01 -08:00
committed by Tim Abbott
parent 800e38016a
commit 64268f47e8
2 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tools/tests/test_check_rabbitmq_queue.py
View File

@@ -25,7 +25,6 @@ class AnalyzeQueueStatsTests(TestCase):
"name",
{
"update_time": time.time(),
"current_queue_size": 10000,
"recent_average_consume_time": None,
},
10000,
@@ -38,7 +37,6 @@ class AnalyzeQueueStatsTests(TestCase):
"name",
{
"update_time": time.time(),
"current_queue_size": 10000,
"queue_last_emptied_timestamp": time.time() - 10000,
"recent_average_consume_time": 1,
},
@@ -52,7 +50,6 @@ class AnalyzeQueueStatsTests(TestCase):
"name",
{
"update_time": time.time(),
"current_queue_size": 10000,
"queue_last_emptied_timestamp": time.time() - 10000,
"recent_average_consume_time": 0.0001,
},
@@ -66,7 +63,6 @@ class AnalyzeQueueStatsTests(TestCase):
"name",
{
"update_time": time.time(),
"current_queue_size": 11,
"queue_last_emptied_timestamp": time.time() - 10000,
"recent_average_consume_time": 1,
},
@@ -79,7 +75,6 @@ class AnalyzeQueueStatsTests(TestCase):
"name",
{
"update_time": time.time(),
"current_queue_size": 9,
"queue_last_emptied_timestamp": time.time() - 10000,
"recent_average_consume_time": 1,
},