paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename get_realm_human_user_ids -> get_active_user_ids.

Browse Source 
The function name `get_realm_human_user_ids` was a lie--it
includes active bots as well.

The only user of this function is `activity.js`, which wasn't
impacted by the misleading name, because we eventually filter
out bots in the `info_for` function.

It's possible that we actually want to include bots in the right
sidebar, since they can be difficult to discover in other parts
of the UI.  Or, if we want to keep the right sidebar as all
human users, we may eventually want to make the logic to exclude
bots happen higher in the stack (but for real, this time).
This commit is contained in:
Steve Howell
2017-10-26 09:17:43 -07:00
parent 03805fdca4
commit 646bd356a3
3 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
static/js/people.js
View File

@@ -553,9 +553,8 @@ exports.get_realm_persons = function () {
return realm_people_dict.values();
};
exports.get_realm_human_user_ids = function () {
// This returns user_ids for all non-bot users
// in the realm.
exports.get_active_user_ids = function () {
// This includes active users and active bots.
return realm_people_dict.keys();
};