paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 18:06:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

blueslip: Reduce cardinality of blueslip.error() calls.

Browse Source 
Particularly when grouping in Sentry, pushing the ids and such into
the additional data section helps group like errors together better.
This commit is contained in:
Alex Vandiver
2023-04-24 13:57:45 +00:00
committed by Tim Abbott
parent 1769f981da
commit 64b277d845
60 changed files with 148 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/message_edit.js
View File

@@ -585,7 +585,7 @@ function start_edit_with_content($row, content, edit_box_open_callback) {
export function start($row, edit_box_open_callback) {
const message = message_lists.current.get(rows.id($row));
if (message === undefined) {
blueslip.error("Couldn't find message ID for edit " + rows.id($row));
blueslip.error("Couldn't find message ID for edit", {row_id: rows.id($row)});
return;
}
@@ -1037,7 +1037,7 @@ export function edit_last_sent_message() {
if (!$msg_row) {
// This should never happen, since we got the message above
// from message_lists.current.
blueslip.error("Could not find row for id " + msg.id);
blueslip.error("Could not find row for id", {msg_id: msg.id});
return;
}