paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

puppeteer: Wait till visible: true in check_messages_sent.

Browse Source 
The next adds a few tests which heavily rely on
check_messages_sent. There were some weird errors,
this fixed those. I think the errors were due to
us navigating multiple times and this function
not waiting for the messages to become visible.
This commit is contained in:
Dinesh
2020-08-30 07:48:11 +00:00
committed by Tim Abbott
parent 28d65b391c
commit 653a577abb
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend_tests/puppeteer_lib/common.js
View File

@@ -390,7 +390,7 @@ class CommonUtils {
// The method will only check that all the messages in the
// messages array passed exist in the order they are passed.
async check_messages_sent(page, table, messages) {
await page.waitForSelector("#" + table);
await page.waitForSelector("#" + table, {visible: true});
const rendered_messages = await this.get_rendered_messages(page, table);
// We only check the last n messages because if we run