paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 14:35:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

webhooks: Add missing space in Review Board.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2021-12-16 20:12:13 -08:00
committed by Anders Kaseorg
parent c02c053ec3
commit 65868b09eb
4 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/overview/changelog.md
View File

@@ -1280,7 +1280,7 @@ details.
- Added /digest endpoint for viewing the current digest email on the web. - Added /digest endpoint for viewing the current digest email on the web.
- Added alert for when a user sends a message when scrolled too far up. - Added alert for when a user sends a message when scrolled too far up.
- Added internationalization for outgoing emails. - Added internationalization for outgoing emails.
- Added a ReviewBoard integration, and improved numerous existing integrations. - Added a Review Board integration, and improved numerous existing integrations.
- Added support for multi-line messages for the /me feature. - Added support for multi-line messages for the /me feature.
- Added Markdown rendering of text when displaying custom profile fields. - Added Markdown rendering of text when displaying custom profile fields.
- Added "silent mentions" syntax (`@_**Tim Abbott**`), which show - Added "silent mentions" syntax (`@_**Tim Abbott**`), which show

2
zerver/lib/integrations.py
View File

@@ -431,7 +431,7 @@ WEBHOOK_INTEGRATIONS: List[WebhookIntegration] = [
WebhookIntegration("pivotal", ["project-management"], display_name="Pivotal Tracker"), WebhookIntegration("pivotal", ["project-management"], display_name="Pivotal Tracker"),
WebhookIntegration("radarr", ["entertainment"], display_name="Radarr"), WebhookIntegration("radarr", ["entertainment"], display_name="Radarr"),
WebhookIntegration("raygun", ["monitoring"], display_name="Raygun"), WebhookIntegration("raygun", ["monitoring"], display_name="Raygun"),
WebhookIntegration("reviewboard", ["version-control"], display_name="ReviewBoard"), WebhookIntegration("reviewboard", ["version-control"], display_name="Review Board"),
WebhookIntegration("semaphore", ["continuous-integration", "deployment"]), WebhookIntegration("semaphore", ["continuous-integration", "deployment"]),
WebhookIntegration("sentry", ["monitoring"]), WebhookIntegration("sentry", ["monitoring"]),
WebhookIntegration( WebhookIntegration(

4
zerver/webhooks/reviewboard/doc.md
View File

@@ -1,10 +1,10 @@
Get ReviewBoard notifications in Zulip! Get Review Board notifications in Zulip!
1. {!create-stream.md!} 1. {!create-stream.md!}
1. {!create-bot-construct-url-indented.md!} 1. {!create-bot-construct-url-indented.md!}
1. On your ReviewBoard **Dashboard**, click your team's name in the top-right 1. On your Review Board **Dashboard**, click your team's name in the top-right
corner, and click **Team administration**. Select **WebHooks** on the corner, and click **Team administration**. Select **WebHooks** on the
left sidebar, and click **+ Create a WebHook**. left sidebar, and click **+ Create a WebHook**.

4
zerver/webhooks/reviewboard/view.py
View File

@@ -182,7 +182,9 @@ def api_reviewboard_webhook(
user_profile: UserProfile, user_profile: UserProfile,
payload: Dict[str, Sequence[Dict[str, Any]]] = REQ(argument_type="body"), payload: Dict[str, Sequence[Dict[str, Any]]] = REQ(argument_type="body"),
) -> HttpResponse: ) -> HttpResponse:
event_type = validate_extract_webhook_http_header(request, "X_REVIEWBOARD_EVENT", "ReviewBoard") event_type = validate_extract_webhook_http_header(
request, "X_REVIEWBOARD_EVENT", "Review Board"
)
assert event_type is not None assert event_type is not None
body_function = RB_MESSAGE_FUNCTIONS.get(event_type) body_function = RB_MESSAGE_FUNCTIONS.get(event_type)