mirror of
https://github.com/zulip/zulip.git
synced 2025-11-02 13:03:29 +00:00
emoji tests: Clean up data setup.
With update_emojis, it is pretty easy to set up the tests with reasonable data without reaching into internal data structures. Also, we can begin the process of sharing the same data with our dispatch tests (upcoming).
This commit is contained in:
@@ -1,13 +1,18 @@
|
||||
const events = require("./lib/events.js");
|
||||
|
||||
zrequire("emoji");
|
||||
|
||||
const realm_emojis = events.fixtures.realm_emoji.realm_emoji;
|
||||
|
||||
emoji.update_emojis(realm_emojis);
|
||||
|
||||
run_test("sanity check", () => {
|
||||
assert.equal(emoji.get_server_realm_emoji_data(), realm_emojis);
|
||||
});
|
||||
|
||||
run_test("get_canonical_name", () => {
|
||||
emoji.active_realm_emojis = new Map(
|
||||
Object.entries({
|
||||
realm_emoji: "TBD",
|
||||
}),
|
||||
);
|
||||
let canonical_name = emoji.get_canonical_name("realm_emoji");
|
||||
assert.equal(canonical_name, "realm_emoji");
|
||||
let canonical_name = emoji.get_canonical_name("green_tick");
|
||||
assert.equal(canonical_name, "green_tick");
|
||||
|
||||
canonical_name = emoji.get_canonical_name("thumbs_up");
|
||||
assert.equal(canonical_name, "+1");
|
||||
@@ -22,19 +27,6 @@ run_test("get_canonical_name", () => {
|
||||
emoji.get_canonical_name("non_existent");
|
||||
});
|
||||
|
||||
function set_up_spain_realm_emoji_for_test() {
|
||||
const realm_emojis = {
|
||||
101: {
|
||||
id: 101,
|
||||
name: "spain",
|
||||
source_url: "/some/path/to/spain.png",
|
||||
deactivated: false,
|
||||
},
|
||||
};
|
||||
emoji.update_emojis(realm_emojis);
|
||||
assert.equal(emoji.get_server_realm_emoji_data(), realm_emojis);
|
||||
}
|
||||
|
||||
run_test("get_emoji_* API", () => {
|
||||
assert.equal(emoji.get_emoji_name("1f384"), "holiday_tree");
|
||||
assert.equal(emoji.get_emoji_name("1f951"), "avocado");
|
||||
@@ -44,7 +36,5 @@ run_test("get_emoji_* API", () => {
|
||||
assert.equal(emoji.get_emoji_codepoint("holiday_tree"), "1f384");
|
||||
assert.equal(emoji.get_emoji_codepoint("bogus"), undefined);
|
||||
|
||||
assert.equal(emoji.get_realm_emoji_url("spain"), undefined);
|
||||
set_up_spain_realm_emoji_for_test();
|
||||
assert.equal(emoji.get_realm_emoji_url("spain"), "/some/path/to/spain.png");
|
||||
});
|
||||
|
||||
@@ -307,8 +307,18 @@ exports.fixtures = {
|
||||
realm_emoji: {
|
||||
type: "realm_emoji",
|
||||
realm_emoji: {
|
||||
airplane: {
|
||||
source_url: "some_url",
|
||||
101: {
|
||||
id: "101",
|
||||
name: "spain",
|
||||
source_url: "/some/path/to/spain.png",
|
||||
deactivated: false,
|
||||
},
|
||||
102: {
|
||||
id: "102",
|
||||
name: "green_tick",
|
||||
author_id: 222,
|
||||
deactivated: false,
|
||||
source_url: "/some/path/to/emoji",
|
||||
},
|
||||
},
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user