From 6653e19e3aa5f8f9128a2507cf5b43c15b056d67 Mon Sep 17 00:00:00 2001 From: Cory Lynch Date: Fri, 9 Jun 2017 01:17:00 -0400 Subject: [PATCH] Add URL for viewing node coverage data on dev server. Running test-js-with-node --coverage now provides a URL to view the output data on the web. Fixes #5177. --- tools/test-js-with-node | 2 ++ zerver/lib/test_helpers.py | 1 + zproject/dev_urls.py | 4 ++++ 3 files changed, 7 insertions(+) diff --git a/tools/test-js-with-node b/tools/test-js-with-node index 13e0c73d9b..33a7729575 100755 --- a/tools/test-js-with-node +++ b/tools/test-js-with-node @@ -132,6 +132,8 @@ if options.coverage and ret == 0: print() if ret == 0: + if options.coverage: + print("View coverage reports at http://127.0.0.1:9991/node-coverage/index.html") print("Test(s) passed. SUCCESS!") else: print("FAIL - Test(s) failed") diff --git a/zerver/lib/test_helpers.py b/zerver/lib/test_helpers.py index 1c54f11b83..fdc522e199 100644 --- a/zerver/lib/test_helpers.py +++ b/zerver/lib/test_helpers.py @@ -396,6 +396,7 @@ def write_instrumentation_reports(full_suite): # static content URLs, since the content they point to may # or may not exist. 'coverage/(?P.*)', + 'node-coverage/(?P.*)', 'docs/(?P.*)', ]) diff --git a/zproject/dev_urls.py b/zproject/dev_urls.py index 877b616c24..86021f8a86 100644 --- a/zproject/dev_urls.py +++ b/zproject/dev_urls.py @@ -19,6 +19,10 @@ urls = [ serve, {'document_root': os.path.join(settings.DEPLOY_ROOT, 'var/coverage'), 'show_indexes': True}), + url(r'^node-coverage/(?P.*)$', + serve, {'document_root': + os.path.join(settings.DEPLOY_ROOT, 'var/node-coverage/lcov-report'), + 'show_indexes': True}), url(r'^docs/(?P.*)$', serve, {'document_root': os.path.join(settings.DEPLOY_ROOT, 'docs/_build/html')}),