From 669f482b0d1ee7faaf1d9fa40560291bc637d6d1 Mon Sep 17 00:00:00 2001
From: YashRE42 <33805964+YashRE42@users.noreply.github.com>
Date: Thu, 21 May 2020 11:50:49 +0530
Subject: [PATCH] icons: Switch from text-o to code-o for view source / edit
 topics.

This commit replaces fa-file-text-o with fa-file-code-o which is a
better signal for the "view source" action. It also deletes a single
line comment that had suggested the change once we moved into font
awesome 4, which Aditya Bansal <adi.bansal241996@gmail.com> helped
out in doing, first via
91962aa6ab9cdbca483313efc92c59053c397623 and most recently via
75ae94e4597270b54712f63bd621a3ac540b8205 with several commits in
between.
---
 docs/documentation/user.md                        | 4 ++--
 static/js/ui_init.js                              | 2 +-
 static/templates/actions_popover_content.hbs      | 3 +--
 templates/zerver/help/edit-or-delete-a-message.md | 2 +-
 4 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/docs/documentation/user.md b/docs/documentation/user.md
index 44fb83cb7f..319deab31a 100644
--- a/docs/documentation/user.md
+++ b/docs/documentation/user.md
@@ -147,8 +147,8 @@ class="fa fa-cog"></i>) icon`
 `down chevron (<i class="fa fa-chevron-down"></i>) icon`
 * eye (<i class="fa fa-eye"></i>) icon — `eye (<i
 class="fa fa-eye"></i>) icon`
-* file (<i class="fa fa-file-text-o"></i>) icon — `file (<i
-class="fa fa-file-text-o"></i>) icon`
+* file (<i class="fa fa-file-code-o"></i>) icon — `file (<i
+class="fa fa-file-code-o"></i>) icon`
 * filled star (<i class="fa fa-star"></i>) icon —
 `filled star (<i class="fa fa-star"></i>) icon`
 * formatting (<i class="fa fa-font"></i>) icon —
diff --git a/static/js/ui_init.js b/static/js/ui_init.js
index 3c7f876199..10cb6ae0be 100644
--- a/static/js/ui_init.js
+++ b/static/js/ui_init.js
@@ -41,7 +41,7 @@ function message_hover(message_row) {
         !message.status_message) {
         message_row.find(".edit_content").html('<i class="fa fa-pencil edit_content_button" aria-hidden="true" title="Edit (e)"></i>');
     } else {
-        message_row.find(".edit_content").html('<i class="fa fa-file-text-o edit_content_button" aria-hidden="true" title="View source (e)" data-message-id="' + id + '"></i>');
+        message_row.find(".edit_content").html('<i class="fa fa-file-code-o edit_content_button" aria-hidden="true" title="View source (e)" data-message-id="' + id + '"></i>');
     }
 }
 
diff --git a/static/templates/actions_popover_content.hbs b/static/templates/actions_popover_content.hbs
index 104c72331f..f7ef005a88 100644
--- a/static/templates/actions_popover_content.hbs
+++ b/static/templates/actions_popover_content.hbs
@@ -3,8 +3,7 @@
     {{#if should_display_edit_and_view_source}}
     <li>
         <a href="#" class="popover_edit_message" data-message-id="{{message_id}}">
-            {{! Can consider https://fontawesome.com/v4.7.0/icon/file-code-o when we upgrade to font awesome 4.}}
-            <i class="{{#if use_edit_icon}}fa fa-pencil{{else}}fa fa-file-text-o{{/if}}" aria-hidden="true"></i> {{editability_menu_item}}
+            <i class="{{#if use_edit_icon}}fa fa-pencil{{else}}fa fa-file-code-o{{/if}}" aria-hidden="true"></i> {{editability_menu_item}}
         </a>
     </li>
     {{/if}}
diff --git a/templates/zerver/help/edit-or-delete-a-message.md b/templates/zerver/help/edit-or-delete-a-message.md
index 677b1f9324..5b512c52d1 100644
--- a/templates/zerver/help/edit-or-delete-a-message.md
+++ b/templates/zerver/help/edit-or-delete-a-message.md
@@ -31,7 +31,7 @@ content.
     [disabled by an organization administrator](/help/disable-message-edit-history).
 
 If you don't see the pencil (<i class="fa fa-pencil"></i>) icon, the message content
-can no longer be edited. You should see a file (<i class="fa fa-file-text-o"></i>)
+can no longer be edited. You should see a file (<i class="fa fa-file-code-o"></i>)
 icon instead. Clicking the file icon will allow you to view the
 [Markdown source](/help/view-the-markdown-source-of-a-message) of the message, or
 [edit the topic](/help/change-the-topic-of-a-message).