paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

channel_folders: Add tests for case-insensitive duplicate name check.

Browse Source 
This commit adds tests for checking the requirement of folder
names to be unique case insensitively.
This commit is contained in:
Sahil Batra
2025-05-21 13:00:33 +05:30
committed by Tim Abbott
parent 88b47be938
commit 677390d3f6
2 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/lib/channel_folders.py
View File

@@ -33,7 +33,7 @@ def check_channel_folder_name(name: str, realm: Realm) -> None:
)
if ChannelFolder.objects.filter(name__iexact=name, realm=realm).exists():
raise JsonableError(_("Channel folder '{name}' already exists").format(name=name))
raise JsonableError(_("Channel folder name already in use"))
def render_channel_folder_description(text: str, realm: Realm, *, acting_user: UserProfile) -> str:

14
zerver/tests/test_channel_folders.py
View File

@@ -37,7 +37,12 @@ class ChannelFolderCreationTest(ZulipTestCase):
self.assertTrue(ChannelFolder.objects.filter(realm=realm, name="Frontend").exists())
result = self.client_post("/json/channel_folders/create", params)
self.assert_json_error(result, "Channel folder 'Frontend' already exists")
self.assert_json_error(result, "Channel folder name already in use")
# Folder names should be unique case-insensitively.
params["name"] = "frontEND"
result = self.client_post("/json/channel_folders/create", params)
self.assert_json_error(result, "Channel folder name already in use")
def test_rendered_description_for_channel_folder(self) -> None:
self.login("iago")
@@ -204,7 +209,12 @@ class UpdateChannelFoldersTest(ZulipTestCase):
params = {"name": "Backend"}
result = self.client_patch(f"/json/channel_folders/{channel_folder_id}", params)
self.assert_json_error(result, "Channel folder 'Backend' already exists")
self.assert_json_error(result, "Channel folder name already in use")
# Folder names should be unique case-insensitively.
params = {"name": "backEND"}
result = self.client_patch(f"/json/channel_folders/{channel_folder_id}", params)
self.assert_json_error(result, "Channel folder name already in use")
invalid_name = "abc\000"
params = {"name": invalid_name}