paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 03:41:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

streams: Show warning when unsubscribing a private stream.

Browse Source 
We show a modal as a warning when unsubscribing a private stream
because it is a irreversible action and one cannot re-subscribe
tovit until added by other member of stream.

Fixes #9254.
This commit is contained in:
sahil839
2020-08-07 04:08:19 +05:30
committed by Tim Abbott
parent 60f486d941
commit 677ba4bc25
4 changed files with 60 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
static/js/stream_edit.js
View File

@@ -5,10 +5,12 @@ import render_stream_member_list_entry from "../templates/stream_member_list_ent
import render_stream_subscription_info from "../templates/stream_subscription_info.hbs";
import render_subscription_settings from "../templates/subscription_settings.hbs";
import render_subscription_stream_privacy_modal from "../templates/subscription_stream_privacy_modal.hbs";
import render_unsubscribe_private_stream_modal from "../templates/unsubscribe_private_stream_modal.hbs";
import * as blueslip from "./blueslip";
import * as browser_history from "./browser_history";
import * as channel from "./channel";
import * as confirm_dialog from "./confirm_dialog";
import * as hash_util from "./hash_util";
import {i18n} from "./i18n";
import * as input_pill from "./input_pill";
@@ -818,6 +820,24 @@ export function initialize() {
.removeClass("text-success");
}
function remove_user_from_private_stream() {
remove_user_from_stream(target_user_id, sub, removal_success, removal_failure);
}
if (sub.invite_only && people.is_my_user_id(target_user_id)) {
const modal_parent = $("#subscriptions_table");
const html_body = render_unsubscribe_private_stream_modal();
confirm_dialog.launch({
parent: modal_parent,
html_heading: i18n.t("Unsubscribe from __stream_name__", {stream_name: sub.name}),
html_body,
html_yes_button: i18n.t("Yes, unsubscribe from this stream"),
on_click: remove_user_from_private_stream,
});
return;
}
remove_user_from_stream(target_user_id, sub, removal_success, removal_failure);
});
@@ -829,7 +849,7 @@ export function initialize() {
const stream_row = $(
`#subscriptions_table div.stream-row[data-stream-id='${CSS.escape(sub.stream_id)}']`,
);
subs.sub_or_unsub(sub, stream_row);
subs.sub_or_unsub(sub, false, stream_row);
if (!sub.subscribed) {
open_edit_panel_for_row(stream_row);