paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-31 20:13:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

tooltips: Use group ID instead of name for tooltip IDs.

Browse Source 
Previously, tooltip templates were identified using the
group's name in their `id` attributes.

This change uses the group's ID instead, which is more reliable.
This commit is contained in:
Maneesh Shukla
2025-08-15 01:13:12 +05:30
committed by Tim Abbott
parent daa98c72d3
commit 6787a14d74
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
web/templates/user_group_settings/browse_user_groups_list_item.hbs
View File

@@ -1,8 +1,8 @@
<div class="group-row {{#if deactivated}}deactivated-group{{/if}}" data-group-id="{{id}}" data-group-name="{{name}}"> <div class="group-row {{#if deactivated}}deactivated-group{{/if}}" data-group-id="{{id}}" data-group-name="{{name}}">
{{#if is_member}} {{#if is_member}}
<div class="check checked join_leave_button {{#unless can_leave}}disabled{{/unless}} {{#unless is_direct_member}}not-direct-member{{/unless}}"> <div class="check checked join_leave_button {{#unless can_leave}}disabled{{/unless}} {{#unless is_direct_member}}not-direct-member{{/unless}}">
<div class="tippy-zulip-tooltip" data-tooltip-template-id="{{#if can_leave}}{{#if is_direct_member}}leave-{{name}}-group-tooltip-template{{else}}cannot-leave-{{name}}-because-of-subgroup-tooltip-template{{/if}}{{else}}cannot-leave-{{name}}-group-tooltip-template{{/if}}"> <div class="tippy-zulip-tooltip" data-tooltip-template-id="{{#if can_leave}}{{#if is_direct_member}}leave-{{id}}-group-tooltip-template{{else}}cannot-leave-{{id}}-because-of-subgroup-tooltip-template{{/if}}{{else}}cannot-leave-{{id}}-group-tooltip-template{{/if}}">
<template id="leave-{{name}}-group-tooltip-template"> <template id="leave-{{id}}-group-tooltip-template">
<span> <span>
{{#tr}} {{#tr}}
Leave group {name} Leave group {name}
@@ -10,7 +10,7 @@
</span> </span>
</template> </template>
<template id="cannot-leave-{{name}}-because-of-subgroup-tooltip-template"> <template id="cannot-leave-{{id}}-because-of-subgroup-tooltip-template">
<span> <span>
{{#tr}} {{#tr}}
You are a member of this group because you are a member of a subgroup (<z-highlight>{associated_subgroup_names}</z-highlight>). You are a member of this group because you are a member of a subgroup (<z-highlight>{associated_subgroup_names}</z-highlight>).
@@ -19,7 +19,7 @@
</span> </span>
</template> </template>
<template id="cannot-leave-{{name}}-group-tooltip-template"> <template id="cannot-leave-{{id}}-group-tooltip-template">
{{#if deactivated}} {{#if deactivated}}
<span> <span>
{{#tr}} {{#tr}}
@@ -43,8 +43,8 @@
</div> </div>
{{else}} {{else}}
<div class="check join_leave_button {{#unless can_join}}disabled{{/unless}}"> <div class="check join_leave_button {{#unless can_join}}disabled{{/unless}}">
<div class="tippy-zulip-tooltip" data-tooltip-template-id="{{#if can_join}}join-{{name}}-group-tooltip-template{{else}}cannot-join-{{name}}-group-tooltip-template{{/if}}"> <div class="tippy-zulip-tooltip" data-tooltip-template-id="{{#if can_join}}join-{{id}}-group-tooltip-template{{else}}cannot-join-{{id}}-group-tooltip-template{{/if}}">
<template id="join-{{name}}-group-tooltip-template"> <template id="join-{{id}}-group-tooltip-template">
<span> <span>
{{#tr}} {{#tr}}
Join group {name} Join group {name}
@@ -52,7 +52,7 @@
</span> </span>
</template> </template>
<template id="cannot-join-{{name}}-group-tooltip-template"> <template id="cannot-join-{{id}}-group-tooltip-template">
{{#if deactivated}} {{#if deactivated}}
<span> <span>
{{#tr}} {{#tr}}