paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

cache: validate_cache_key in cache_delete_many may get other prefixes.

Browse Source
This commit is contained in:
Alex Vandiver
2025-03-05 15:44:50 +00:00
committed by Tim Abbott
parent ae6acd9f05
commit 67bea1f103
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/lib/cache.py
View File

@@ -199,8 +199,8 @@ def log_invalid_cache_keys(stack_trace: str, key: list[str]) -> None:
) )
def validate_cache_key(key: str) -> None: def validate_cache_key(key: str, auto_prepend_prefix: bool = True) -> None:
if not key.startswith(KEY_PREFIX): if auto_prepend_prefix and not key.startswith(KEY_PREFIX):
key = KEY_PREFIX + key key = KEY_PREFIX + key
# Theoretically memcached can handle non-ascii characters # Theoretically memcached can handle non-ascii characters
@@ -311,7 +311,7 @@ def cache_delete_many(items: Iterable[str], cache_name: str | None = None) -> No
for key_prefix in get_all_cache_key_prefixes(): for key_prefix in get_all_cache_key_prefixes():
keys += [key_prefix + item for item in items] keys += [key_prefix + item for item in items]
for key in keys: for key in keys:
validate_cache_key(key) validate_cache_key(key, auto_prepend_prefix=False)
remote_cache_stats_start() remote_cache_stats_start()
get_cache_backend(cache_name).delete_many(keys) get_cache_backend(cache_name).delete_many(keys)
remote_cache_stats_finish() remote_cache_stats_finish()