paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Use container variable for accessing top-level element.

Browse Source 
This change was missed in 032d347b4f.
This commit is contained in:
Sahil Batra
2021-08-26 13:40:41 +05:30
committed by Tim Abbott
parent 1b530e74d2
commit 67d534869c
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
static/js/settings_notifications.js
View File

@@ -51,9 +51,10 @@ function change_notification_setting(setting, value, status_element) {
} }
function update_desktop_icon_count_display() { function update_desktop_icon_count_display() {
$("#user-notification-settings .setting_desktop_icon_count_display").val( const container = $("#user-notification-settings");
user_settings.desktop_icon_count_display, container
); .find(".setting_desktop_icon_count_display")
.val(user_settings.desktop_icon_count_display);
unread_ui.update_unread_counts(); unread_ui.update_unread_counts();
} }
@@ -77,7 +78,7 @@ export function set_enable_marketing_emails_visibility() {
export function set_up() { export function set_up() {
const container = $("#user-notification-settings"); const container = $("#user-notification-settings");
$("#user-notification-settings").on("change", "input, select", function (e) { container.on("change", "input, select", function (e) {
e.preventDefault(); e.preventDefault();
e.stopPropagation(); e.stopPropagation();
const input_elem = $(e.currentTarget); const input_elem = $(e.currentTarget);
@@ -134,6 +135,7 @@ export function set_up() {
} }
export function update_page() { export function update_page() {
const container = $("#user-notification-settings");
for (const setting of settings_config.all_notification_settings) { for (const setting of settings_config.all_notification_settings) {
if ( if (
setting === "enable_offline_push_notifications" && setting === "enable_offline_push_notifications" &&
@@ -146,14 +148,10 @@ export function update_page() {
update_desktop_icon_count_display(); update_desktop_icon_count_display();
continue; continue;
} else if (setting === "notification_sound") { } else if (setting === "notification_sound") {
$("#user-notification-settings .setting_notification_sound").val( container.find(".setting_notification_sound").val(user_settings.notification_sound);
user_settings.notification_sound,
);
} }
$("#user-notification-settings") container.find(`.${CSS.escape(setting)}`).prop("checked", user_settings[setting]);
.find(`.${CSS.escape(setting)}`)
.prop("checked", user_settings[setting]);
} }
rerender_ui(); rerender_ui();
} }