paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-12 01:47:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

app_components: Refactor table-bordered border color rule.

Browse Source 
This optional commit also fixes #30431. It refactors the CSS
for the .table-bordered class, which is used directly by the
tables in the info_overlay menus (keyboard_shortcuts,
search_operators, markdown_help). This approach differs from
PR #30431, where the CSS for .overlay_body—a wrapper div
around these tables—was edited instead.

This commit make the CSS rules for .table-bordered class
use a new CSS variable for its border color where appropriate.
This is aligns with how we organizes CSS in #29859 and in
cd63e8d93cb0f84ec1e4ead348a225cb798f9cf0.

Fixes #39431.
This commit is contained in:
PieterCK
2024-06-17 15:34:32 +07:00
committed by Tim Abbott
parent 2c7f8ef4a1
commit 681adc1a75
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/styles/app_components.css
View File

@@ -799,7 +799,7 @@ div.overlay {
} }
.table-bordered { .table-bordered {
border: 1px solid hsl(0deg 0% 87%); border: 1px solid var(--color-border-table-bordered);
border-collapse: separate; border-collapse: separate;
border-left: 0; border-left: 0;
border-radius: 4px; border-radius: 4px;
@@ -809,8 +809,8 @@ div.overlay {
& th, & th,
td { td {
border-left: 1px solid hsl(0deg 0% 87%); border-left: 1px solid var(--color-border-table-bordered);
border-top: 1px solid hsl(0deg 0% 87%); border-top: 1px solid var(--color-border-table-bordered);
padding: 4px 5px; padding: 4px 5px;
text-align: left; text-align: left;
} }

2
web/styles/app_variables.css
View File

@@ -389,6 +389,7 @@
/* Settings table colors */ /* Settings table colors */
--color-border-table-striped: hsl(0deg 0% 87%); --color-border-table-striped: hsl(0deg 0% 87%);
--color-border-table-bordered: hsl(0deg 0% 87%);
/* Markdown code colors */ /* Markdown code colors */
--color-markdown-code-text: hsl(0deg 0% 0%); --color-markdown-code-text: hsl(0deg 0% 0%);
@@ -747,6 +748,7 @@
/* Settings table colors */ /* Settings table colors */
--color-border-table-striped: hsl(0deg 0% 0% / 20%); --color-border-table-striped: hsl(0deg 0% 0% / 20%);
--color-border-table-bordered: hsl(0deg 0% 0% / 20%);
/* Markdown code colors */ /* Markdown code colors */
/* Note that Markdown code-link colors are identical /* Note that Markdown code-link colors are identical