From 68c83bce4400f526dcb8ffe32bb22fc5a69b1e97 Mon Sep 17 00:00:00 2001 From: N-Shar-ma Date: Thu, 23 May 2024 03:57:12 +0530 Subject: [PATCH] widgets: Fix bug where `process_submessages()` was run for empty rows. We now check if the row exists in the current view, and only then do we process the submessages in it, instead of letting `Error: Failed to do_process_submessages` happen. --- web/src/submessage.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/web/src/submessage.ts b/web/src/submessage.ts index 7b754b9886..1e2500bf51 100644 --- a/web/src/submessage.ts +++ b/web/src/submessage.ts @@ -90,8 +90,9 @@ export function get_message_events(message: Message): SubmessageEvents | undefin export function process_widget_rows_in_list(list: MessageList | undefined): void { for (const message_id of widgetize.widget_event_handlers.keys()) { - if (list?.get(message_id) !== undefined) { - process_submessages({message_id, $row: list.get_row(message_id)}); + const $row = list?.get_row(message_id); + if ($row && $row.length !== 0) { + process_submessages({message_id, $row}); } } }