From 68c9866a6e5438f52f99f3330e23c578f5f4d5a2 Mon Sep 17 00:00:00 2001 From: Sayam Samal Date: Tue, 8 Apr 2025 22:44:46 +0530 Subject: [PATCH] tests: Fix admin.test.ts puppeteer test case failing. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The puppeteer test case for checking the save discard widget button states was failing sometimes as the button was being updated too soon. Due to this, sometimes the assertion check would execute after the button label has already been updated — resulting in mismatched results. (cherry picked from commit e1acec52eb99b6f1670e00483648544c37b14eb1) --- web/e2e-tests/admin.test.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/web/e2e-tests/admin.test.ts b/web/e2e-tests/admin.test.ts index 3422e2c94f..cc153708f5 100644 --- a/web/e2e-tests/admin.test.ts +++ b/web/e2e-tests/admin.test.ts @@ -10,11 +10,8 @@ async function submit_announcements_stream_settings(page: Page): Promise { }); const save_button = "#org-notifications .save-button"; - assert.strictEqual( - await common.get_text_from_selector(page, save_button), - "Save changes", - "Save button has incorrect text.", - ); + const button_text = await common.get_text_from_selector(page, save_button); + assert.strictEqual(button_text, "Save changes", "Save button has incorrect text."); await page.click(save_button); await page.waitForSelector('#org-notifications .save-button[data-status="saved"]', {