paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 20:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings_users: Refactor and extract function for last active.

Browse Source 
This just done to improves code readability and removes some code too.
This commit is contained in:
Pragati Agrawal
2019-08-15 16:27:43 +05:30
committed by Tim Abbott
parent c0c11fe226
commit 693df05ca7
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
static/js/settings_users.js
View File

@@ -170,29 +170,29 @@ function populate_users(realm_people_data) {
},
}).init();
function get_rendered_last_activity(item) {
var today = new XDate();
if (item.last_active === LAST_ACTIVE_UNKNOWN) {
return $("<span></span>").text(i18n.t("Unknown"));
}
if (item.last_active === LAST_ACTIVE_NEVER) {
return $("<span></span>").text(i18n.t("Never"));
}
return timerender.render_date(
new XDate(item.last_active * 1000), undefined, today);
}
var $users_table = $("#admin_users_table");
list_render.create($users_table, active_users, {
name: "users_table_list",
modifier: function (item) {
var activity_rendered;
var today = new XDate();
if (item.last_active === LAST_ACTIVE_UNKNOWN) {
activity_rendered = $("<span></span>").text(i18n.t("Unknown"));
} else if (item.last_active === LAST_ACTIVE_NEVER) {
activity_rendered = $("<span></span>").text(i18n.t("Never"));
} else {
activity_rendered = timerender.render_date(
new XDate(item.last_active * 1000), undefined, today);
}
var $row = $(render_admin_user_list({
can_modify: page_params.is_admin,
is_current_user: people.is_my_user_id(item.user_id),
show_email: settings_org.show_email(),
user: item,
}));
$row.find(".last_active").append(activity_rendered);
$row.find(".last_active").append(get_rendered_last_activity(item));
return $row;
},
filter: {