paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove 'All messages' sidebar link.

Browse Source 
Nobody uses it, and it causes confusion. (How is it different from 'Home'?)

For now, leave in the ability to get to the narrow, although we may
ultimately want to do away with it as well.

(imported from commit 35b3f27e39c4de3391bc5571b32f7242a29f4cfa)
This commit is contained in:
Jessica McKellar
2013-10-31 09:21:35 -04:00
parent 020bd9d4e9
commit 69481a0843
3 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
static/js/subs.js
View File

@@ -10,18 +10,6 @@ function get_color() {
return color;
}
exports.update_all_messages_link = function () {
// Show or hide the "All messages" link, depending on whether
// the user has any subscriptions hidden from home view.
var all_messages = $("#global_filters [data-name='all']")[0];
if (stream_data.all_subscribed_streams_are_in_home_view()) {
$(all_messages).addClass('hidden-filter');
} else {
$(all_messages).removeClass('hidden-filter');
}
};
function should_list_all_streams() {
return page_params.domain !== 'mit.edu';
}
@@ -100,7 +88,6 @@ function update_in_home_view(sub, value) {
}
}, 0);
exports.update_all_messages_link();
stream_list.set_in_home_view(sub.name, sub.in_home_view);
var in_home_view_checkbox = $("#subscription_" + sub.id + " #sub_setting_in_home_view .sub_setting_control");

1
static/js/ui.js
View File

@@ -1562,7 +1562,6 @@ $(function () {
hashchange.initialize();
invite.initialize();
activity.initialize();
subs.update_all_messages_link();
tutorial.initialize();
onboarding.initialize();
});

1
templates/zerver/left-sidebar.html
View File

@@ -13,7 +13,6 @@
{# Special-case this link so we don't actually go to page top. #}
<li data-name="home"
class="global-filter active-filter"><i class="icon-vector-home"></i> <a href="#">Home <span class="count"><span class="value"></span></span></a></li>
<li data-name="all" class="global-filter hidden-filter"><i class="icon-vector-list"></i> <a href="#narrow/in/all">All messages</a></li>
<li data-name="private" class="global-filter"><i class="icon-vector-user"></i> <a href="#narrow/is/private">Private messages <span class="count"><span class="value"></span></span></a></li>
<li data-name="starred" class="global-filter"><i class="icon-vector-star"></i> <a href="#narrow/is/starred">Starred messages</a></li>
<li data-name="mentioned" class="global-filter"><i class="icon-vector-tag"></i> <a href="#narrow/is/mentioned">@-mentions<span class="count"><span class="value"></span></span></a></li>