paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 03:41:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

default streams: Change remove api to use stream_id.

Browse Source 
This is a full-stack change:

    - server
    - JS code
    - templates

It's all pretty simple--just use stream_id instead
of stream_name.

I am 99% sure we don't document this API nor use it
in mobile, so it should be a safe change.
This commit is contained in:
Steve Howell
2020-03-22 19:29:49 +00:00
committed by Tim Abbott
parent 2cd9c77979
commit 697b00dd6e
5 changed files with 23 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/settings_streams.js
View File

@@ -78,9 +78,9 @@ function make_stream_default(stream_name) {
});
}
exports.delete_default_stream = function (stream_name, default_stream_row, alert_element) {
exports.delete_default_stream = function (stream_id, default_stream_row, alert_element) {
channel.del({
url: "/json/default_streams" + "?" + $.param({ stream_name: stream_name }),
url: "/json/default_streams" + "?" + $.param({ stream_id: stream_id }),
error: function (xhr) {
ui_report.generic_row_button_error(xhr, alert_element);
},
@@ -135,8 +135,8 @@ exports.build_page = function () {
$("body").on("click", ".default_stream_row .remove-default-stream", function (e) {
const row = $(this).closest(".default_stream_row");
const stream_name = row.attr("id");
exports.delete_default_stream(stream_name, row, $(e.target));
const stream_id = parseInt(row.attr("data-stream-id"), 10);
exports.delete_default_stream(stream_id, row, $(e.target));
});
};