paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

hashchange: Fix near link not working if already narrowed to it.

Browse Source 
In 666ce4519d, we switched to use
`this.href` instead of `e.currentTarget.getAttribute("href")`.

This bugged the behaviour since `this.href` includes the complete
URL including hostname.

Switched to use `this.hash` to fix it.
This commit is contained in:
Aman Agrawal
2025-01-14 11:51:14 +05:30
committed by Tim Abbott
parent 6d495a270e
commit 6a44364a69
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
web/src/hashchange.ts
View File

@@ -562,9 +562,8 @@ export function initialize(): void {
hashchanged(true);
$("body").on("click", "a", function (this: HTMLAnchorElement, e: JQuery.ClickEvent) {
const href = this.href;
if (href === window.location.hash && href.includes("/near/")) {
// The clicked on a link, perhaps a "said" reference, that
if (this.hash === window.location.hash && this.hash.includes("/near/")) {
// User clicked on a link, perhaps a "said" reference, that
// matches the current view. Such a click doesn't trigger
// a hashchange event, so we manually trigger one in order
// to ensure the app scrolls to the correct message.