message: Merge unnecessary cache_transformer step.

Having a non-identity `cache_transformer` is no different from running
it on every row of the query_function.  Simplify understanding of the
codepath used in caching by merging the pieces of code.

(cherry picked from commit 547c8f895d)
This commit is contained in:
Alex Vandiver
2023-10-13 01:53:42 +00:00
committed by Tim Abbott
parent 8b23b81f56
commit 6a6e59f4d6
5 changed files with 12 additions and 18 deletions

View File

@@ -218,15 +218,14 @@ def messages_for_ids(
user_profile: Optional[UserProfile],
realm: Realm,
) -> List[Dict[str, Any]]:
cache_transformer = MessageDict.build_dict_from_raw_db_row
id_fetcher = lambda row: row["id"]
message_dicts = generic_bulk_cached_fetch(
to_dict_cache_key_id,
MessageDict.get_raw_db_rows,
MessageDict.ids_to_dict,
message_ids,
id_fetcher=id_fetcher,
cache_transformer=cache_transformer,
cache_transformer=lambda obj: obj,
extractor=extract_message_dict,
setter=stringify_message_dict,
)