From 6ae613c235842fe6de42feddb60149c58c4726d8 Mon Sep 17 00:00:00 2001
From: Arpith Siromoney <arpith@feedreader.co>
Date: Mon, 5 Dec 2016 12:19:37 +0530
Subject: [PATCH] Eslint: Add additioanl rules, some for GCI.

This commit adds rules for GCI, turns on rules that do not error
on our codebase, and changes frontend_tests/.eslintrc.json's no-sync
rule to off (as per AirBnB's style guide).

Rules for GCI:
no-restricted-syntax, no-nested-ternary, spaced-comment,
space-infix-ops, newline-per-chained-call, padded-blocks,
no-whitespace-before-property, space-in-parens

Rules that do not error:
no-useless-constructor, no-dupe-class-members, no-duplicate-imports,
no-iterator, no-undef, dot-notation, no-case-declarations, no-unneeded-ternary,
eol-last,

Finally, eqeqeq is changed from 2 to ['error', 'allow-null'], going
from jslint defaults to airbnb's recommendation (there were no errors)
---
 .eslintrc.json                | 19 ++++++++++++++++++-
 frontend_tests/.eslintrc.json |  2 +-
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/.eslintrc.json b/.eslintrc.json
index a182278c56..6103f0b182 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -90,6 +90,24 @@
         "unread_ui": false
     },
     "rules": {
+	"no-restricted-syntax": 1,
+	"no-nested-ternary": 1,
+	"spaced-comment": 1,
+	"space-infix-ops": 1,
+	"newline-per-chained-call": 1,
+	"no-whitespace-before-property": 1,
+	"padded-blocks": 1,
+	"space-in-parens": 1,
+	"eol-last": ["error", "always"],
+	"no-unneeded-ternary": ["error", { "defaultAssignment": false }],
+	"no-case-declarations": "error",
+	"eqeqeq": ["error", "allow-null"],
+	"no-duplicate-imports": "error",
+	"no-undef": "error",
+	"dot-notation": ["error", { "allowKeywords": true }],
+	"no-iterator": "error",
+	"no-dupe-class-members": "error",
+        "no-useless-constructor": "error",
         "prefer-const": ["error", {
 	    "destructuring": "any",
             "ignoreReadBeforeAssign": true
@@ -174,7 +192,6 @@
         "complexity": [0, 4],
         "curly": 2,
         "dot-notation": 2,
-        "eqeqeq": 2,
         "guard-for-in": 2,
         "max-depth": [0, 4],
         "max-len": ["error", 100, 2, {
diff --git a/frontend_tests/.eslintrc.json b/frontend_tests/.eslintrc.json
index b84b246fac..939296fa14 100644
--- a/frontend_tests/.eslintrc.json
+++ b/frontend_tests/.eslintrc.json
@@ -11,6 +11,6 @@
 	"window": false
     },
     "rules": {
-	"no-sync": 1
+	"no-sync": 0
     }
 }