paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_list: Fix misleading tooltip.

Browse Source 
When in topic narrow, hovering over the topic's channel, should
correctly show where it would navigate to.
This commit is contained in:
Aman Agrawal
2025-07-09 21:55:13 +05:30
committed by Tim Abbott
parent 4775f9673f
commit 6aec84147b
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
web/src/stream_list.ts
View File

@@ -5,6 +5,7 @@ import * as tippy from "tippy.js";
import render_filter_topics from "../templates/filter_topics.hbs"; import render_filter_topics from "../templates/filter_topics.hbs";
import render_go_to_channel_feed_tooltip from "../templates/go_to_channel_feed_tooltip.hbs"; import render_go_to_channel_feed_tooltip from "../templates/go_to_channel_feed_tooltip.hbs";
import render_go_to_channel_list_of_topics_tooltip from "../templates/go_to_channel_list_of_topics_tooltip.hbs";
import render_stream_privacy from "../templates/stream_privacy.hbs"; import render_stream_privacy from "../templates/stream_privacy.hbs";
import render_stream_sidebar_row from "../templates/stream_sidebar_row.hbs"; import render_stream_sidebar_row from "../templates/stream_sidebar_row.hbs";
import render_stream_subheader from "../templates/streams_subheader.hbs"; import render_stream_subheader from "../templates/streams_subheader.hbs";
@@ -878,7 +879,16 @@ export function initialize_tippy_tooltips(): void {
const current_narrow_stream_id = narrow_state.stream_id(); const current_narrow_stream_id = narrow_state.stream_id();
const current_topic = narrow_state.topic(); const current_topic = narrow_state.topic();
if (current_narrow_stream_id === stream_id && current_topic !== undefined) { if (current_narrow_stream_id === stream_id && current_topic !== undefined) {
instance.setContent(ui_util.parse_html(render_go_to_channel_feed_tooltip())); if (
user_settings.web_channel_default_view ===
web_channel_default_view_values.list_of_topics.code
) {
instance.setContent(
ui_util.parse_html(render_go_to_channel_list_of_topics_tooltip()),
);
} else {
instance.setContent(ui_util.parse_html(render_go_to_channel_feed_tooltip()));
}
return undefined; return undefined;
} }
// Then check for truncation // Then check for truncation

2
web/templates/go_to_channel_list_of_topics_tooltip.hbs Normal file
View File

@@ -0,0 +1,2 @@
<div>{{t "Go to list of topics"}}</div>
{{tooltip_hotkey_hints "Y"}}