From 6b3fbab5208b17b7934ea965d742efcbe05f5ae3 Mon Sep 17 00:00:00 2001 From: Lauryn Menard Date: Thu, 8 Dec 2022 12:35:49 +0100 Subject: [PATCH] narrow-banner: Update default empty banner text to be more general. Updates the default empty narrow banner text to be more generally applicable, particularly in the case when all messages have been moved to a new topic. --- frontend_tests/node_tests/narrow.js | 10 +++++----- static/js/narrow_banner.js | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/frontend_tests/node_tests/narrow.js b/frontend_tests/node_tests/narrow.js index ef33fbf178..05954e13f1 100644 --- a/frontend_tests/node_tests/narrow.js +++ b/frontend_tests/node_tests/narrow.js @@ -214,7 +214,7 @@ run_test("show_empty_narrow_message", ({mock_template}) => { assert.equal( $(".empty_feed_notice_main").html(), empty_narrow_html( - "translated: Nothing's been sent here yet!", + "translated: There are no messages here.", 'translated HTML: Why not start the conversation?', ), ); @@ -278,7 +278,7 @@ run_test("show_empty_narrow_message", ({mock_template}) => { narrow_banner.show_empty_narrow_message(); assert.equal( $(".empty_feed_notice_main").html(), - empty_narrow_html("translated: Nothing's been sent here yet!", ""), + empty_narrow_html("translated: There are no messages here.", ""), ); page_params.is_spectator = false; @@ -517,7 +517,7 @@ run_test("show_empty_narrow_message", ({mock_template}) => { assert.equal( $(".empty_feed_notice_main").html(), empty_narrow_html( - "translated: Nothing's been sent here yet!", + "translated: There are no messages here.", 'translated HTML: Why not start the conversation?', ), ); @@ -528,7 +528,7 @@ run_test("show_empty_narrow_message", ({mock_template}) => { assert.equal( $(".empty_feed_notice_main").html(), empty_narrow_html( - "translated: Nothing's been sent here yet!", + "translated: There are no messages here.", 'translated HTML: Why not start the conversation?', ), ); @@ -546,7 +546,7 @@ run_test("show_empty_narrow_message", ({mock_template}) => { assert.equal( $(".empty_feed_notice_main").html(), empty_narrow_html( - "translated: Nothing's been sent here yet!", + "translated: There are no messages here.", 'translated HTML: Why not start the conversation?', ), ); diff --git a/static/js/narrow_banner.js b/static/js/narrow_banner.js index 4d88f6016e..2878f9f930 100644 --- a/static/js/narrow_banner.js +++ b/static/js/narrow_banner.js @@ -66,7 +66,7 @@ function retrieve_search_query_data() { function pick_empty_narrow_banner() { const default_banner = { - title: $t({defaultMessage: "Nothing's been sent here yet!"}), + title: $t({defaultMessage: "There are no messages here."}), // Spectators cannot start a conversation. html: page_params.is_spectator ? ""