paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-31 20:13:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Move pm_conversations.process_message.

Browse Source 
I lift this function out of message_store to
break some dependencies, and it's also more
consistent with the rest of the codebase:

    alert_words.process_message
    pm_conversations.process_message
    recent_topics.process_messages
    recent_senders.process_message_for_senders

We can do further cleanup to make these names
consistent (and possibly have them all work in
bulk), but that's out of the scope of the current PR.
This commit is contained in:
Steve Howell
2021-03-28 16:48:18 +00:00
committed by Tim Abbott
parent 45d806d9aa
commit 6bad6c8837
4 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
static/js/message_helper.js
View File

@@ -2,6 +2,7 @@ import * as alert_words from "./alert_words";
import * as message_store from "./message_store";
import * as message_user_ids from "./message_user_ids";
import * as people from "./people";
import * as pm_conversations from "./pm_conversations";
import * as recent_senders from "./recent_senders";
import * as stream_topic_history from "./stream_topic_history";
import * as util from "./util";
@@ -59,7 +60,7 @@ export function process_new_message(message) {
message.pm_with_url = people.pm_with_url(message);
message.to_user_ids = people.pm_reply_user_string(message);
message_store.process_message_for_recent_private_messages(message);
pm_conversations.process_message(message);
if (people.is_my_user_id(message.sender_id)) {
for (const recip of message.display_recipient) {