paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Refactor settings_display.js code.

Browse Source 
This commit refactors the code in settings_display.js
by modifying the functions to receive the container
element and settings object as parameter such that
we can use the same functions for realm-level
settings by passing appropriate container element
and settings object.

This change is needed as settings_display will be
used as a common module for user settings and realm
level settings.

We also rename the default_language_name variable in
settings_display to user_default_language_name as we
would add a separate variable for realm-level setting
in future.
This commit is contained in:
Sahil Batra
2021-08-18 15:17:07 +05:30
committed by Tim Abbott
parent e127cde3c1
commit 6bae097bf1
4 changed files with 21 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/settings.js
View File

@@ -111,7 +111,7 @@ export function build_page() {
user_can_change_name: settings_data.user_can_change_name(),
user_can_change_avatar: settings_data.user_can_change_avatar(),
user_role_text: people.get_user_type(page_params.user_id),
default_language_name: settings_display.default_language_name,
default_language_name: settings_display.user_default_language_name,
language_list_dbl_col: get_language_list_columns(user_settings.default_language),
settings_object: user_settings,
});