paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-15 19:31:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

popovers: Export focus_first_popover_item function from popovers.js.

Browse Source 
This commit is preparatory commit to adding support for keyboard
navigation by focusing om first menu item of all of our popovers. So
exporting focus_first_popover_item so that it can be reused in other
places.
This commit is contained in:
Mohit Gupta
2020-07-09 00:22:53 +05:30
committed by Tim Abbott
parent f266b52469
commit 6bccadd0b6
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/popovers.js
View File

@@ -561,13 +561,13 @@ function get_action_menu_menu_items() {
return $("li:not(.divider):visible a", popover_data.$tip); return $("li:not(.divider):visible a", popover_data.$tip);
} }
function focus_first_popover_item(items) { exports.focus_first_popover_item = (items) => {
if (!items) { if (!items) {
return; return;
} }
items.eq(0).expectOne().trigger("focus"); items.eq(0).expectOne().trigger("focus");
} };
function popover_items_handle_keyboard(key, items) { function popover_items_handle_keyboard(key, items) {
if (!items) { if (!items) {
@@ -593,7 +593,7 @@ function focus_first_action_popover_item() {
// For now I recommend only calling this when the user opens the menu with a hotkey. // For now I recommend only calling this when the user opens the menu with a hotkey.
// Our popup menus act kind of funny when you mix keyboard and mouse. // Our popup menus act kind of funny when you mix keyboard and mouse.
const items = get_action_menu_menu_items(); const items = get_action_menu_menu_items();
focus_first_popover_item(items); exports.focus_first_popover_item(items);
} }
exports.open_message_menu = function (message) { exports.open_message_menu = function (message) {
@@ -687,7 +687,7 @@ function focus_user_info_popover_item() {
// For now I recommend only calling this when the user opens the menu with a hotkey. // For now I recommend only calling this when the user opens the menu with a hotkey.
// Our popup menus act kind of funny when you mix keyboard and mouse. // Our popup menus act kind of funny when you mix keyboard and mouse.
const items = get_user_info_popover_items(); const items = get_user_info_popover_items();
focus_first_popover_item(items); exports.focus_first_popover_item(items);
} }
exports.user_info_popover_handle_keyboard = function (key) { exports.user_info_popover_handle_keyboard = function (key) {