paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 02:17:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Fix incorrect scroll down notice in recent view.

Browse Source 
The logic for whether one needs to scroll down to view messages sent
by the current client was incorrectly not checking whether a message
feed was visible at all.
This commit is contained in:
Tim Abbott
2023-02-23 11:38:53 -08:00
parent 872a336598
commit 6c82772e15
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
web/src/message_events.js
View File

@@ -141,7 +141,8 @@ export function insert_new_messages(messages, sent_by_this_client) {
// looks at message feed scroll positions to see whether the // looks at message feed scroll positions to see whether the
// newly arrived message will be visible, is only valid if // newly arrived message will be visible, is only valid if
// this message list is the currently visible message list. // this message list is the currently visible message list.
const is_currently_visible = list === message_lists.current; const is_currently_visible =
narrow_state.is_message_feed_visible() && list === message_lists.current;
if (is_currently_visible && render_info && render_info.need_user_to_scroll) { if (is_currently_visible && render_info && render_info.need_user_to_scroll) {
need_user_to_scroll = true; need_user_to_scroll = true;
} }