paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Disallow everyone group for new setting.

Browse Source 
This is important because the "guests" value isn't one that we'd
expect anyone to pick intentionally, and in particular isn't an
available option for the similar/adjacent "email invitations" setting.
This commit is contained in:
Tim Abbott
2023-09-06 17:06:51 -07:00
parent 88ec312b21
commit 6c83bbcbdb
9 changed files with 34 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
web/src/user_groups.ts
View File

@@ -231,8 +231,13 @@ export function get_realm_user_groups_for_dropdown_list_widget(
return [];
}
const {require_system_group, allow_internet_group, allow_owners_group, allow_nobody_group} =
group_setting_config;
const {
require_system_group,
allow_internet_group,
allow_owners_group,
allow_nobody_group,
allow_everyone_group,
} = group_setting_config;
const system_user_groups = settings_config.system_user_groups_list
.filter((group) => {
@@ -248,6 +253,10 @@ export function get_realm_user_groups_for_dropdown_list_widget(
return false;
}
if (!allow_everyone_group && group.name === "role:everyone") {
return false;
}
return true;
})
.map((group) => {