paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Move user-sorting code to people.js.

Browse Source 
We also remove the blueslip check, since it is
pretty easy to audit the callers here.
This commit is contained in:
Steve Howell
2021-12-15 17:48:33 +00:00
committed by Tim Abbott
parent ab8b550cda
commit 6c9427340a
5 changed files with 44 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
static/js/stream_edit.js
View File

@@ -51,10 +51,6 @@ function setup_subscriptions_stream_hash(sub) {
browser_history.update(hash);
}
function compare_by_name(a, b) {
return util.strcmp(a.full_name, b.full_name);
}
export function setup_subscriptions_tab_hash(tab_key_value) {
if (tab_key_value === "all-streams") {
browser_history.update("#streams/all");
@@ -341,23 +337,6 @@ export function remove_user_from_stream(user_id, sub, success, failure) {
});
}
export function sort_but_pin_current_user_on_top(users) {
if (users === undefined) {
blueslip.error("Undefined users are passed to function sort_but_pin_current_user_on_top");
return;
}
const my_user = people.get_by_email(people.my_current_email());
const compare_function = compare_by_name;
if (users.includes(my_user)) {
users.splice(users.indexOf(my_user), 1);
users.sort(compare_function);
users.unshift(my_user);
} else {
users.sort(compare_function);
}
}
export function create_item_from_text(text, current_items) {
const funcs = [
stream_pill.create_item_from_stream_name,
@@ -423,7 +402,7 @@ function enable_subscriber_management({sub, parent_container}) {
const user_ids = peer_data.get_subscribers(stream_id);
const users = get_users_from_subscribers(user_ids);
sort_but_pin_current_user_on_top(users);
people.sort_but_pin_current_user_on_top(users);
function get_users_for_subscriber_typeahead() {
const potential_subscribers = peer_data.potential_subscribers(stream_id);