paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 20:02:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_popover: Extract functions to show sidebar menu icon.

Browse Source
This commit is contained in:
Aman Agrawal
2023-11-06 12:57:29 +00:00
committed by Tim Abbott
parent eaf69dc9d5
commit 6dc17fab57
2 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
web/src/stream_popover.js
View File

@@ -33,16 +33,6 @@ let stream_popover_instance = null;
let stream_widget_value; let stream_widget_value;
let $stream_header_colorblock; let $stream_header_colorblock;
// Keep the menu icon over which the popover is based off visible.
function show_left_sidebar_menu_icon(element) {
$(element).closest(".sidebar-menu-icon").addClass("left_sidebar_menu_icon_visible");
}
// Remove the class from element when popover is closed
function hide_left_sidebar_menu_icon() {
$(".left_sidebar_menu_icon_visible").removeClass("left_sidebar_menu_icon_visible");
}
function get_popover_menu_items(sidebar_elem) { function get_popover_menu_items(sidebar_elem) {
if (!sidebar_elem) { if (!sidebar_elem) {
blueslip.error("Trying to get menu items when action popover is closed."); blueslip.error("Trying to get menu items when action popover is closed.");
@@ -79,7 +69,7 @@ export function is_open() {
export function hide_stream_popover() { export function hide_stream_popover() {
if (is_open()) { if (is_open()) {
hide_left_sidebar_menu_icon(); ui_util.hide_left_sidebar_menu_icon();
stream_popover_instance.destroy(); stream_popover_instance.destroy();
stream_popover_instance = null; stream_popover_instance = null;
} }
@@ -123,7 +113,7 @@ function build_stream_popover(opts) {
}, },
onMount(instance) { onMount(instance) {
const $popper = $(instance.popper); const $popper = $(instance.popper);
show_left_sidebar_menu_icon(elt); ui_util.show_left_sidebar_menu_icon(elt);
// Stream settings // Stream settings
$popper.on("click", ".open_stream_settings", (e) => { $popper.on("click", ".open_stream_settings", (e) => {

10
web/src/ui_util.ts
View File

@@ -121,3 +121,13 @@ export function listener_for_preferred_color_scheme_change(callback: () => void)
media_query_list.addListener(listener); media_query_list.addListener(listener);
} }
} }
// Keep the menu icon over which the popover is based off visible.
export function show_left_sidebar_menu_icon(element: HTMLElement): void {
$(element).closest(".sidebar-menu-icon").addClass("left_sidebar_menu_icon_visible");
}
// Remove the class from element when popover is closed
export function hide_left_sidebar_menu_icon(): void {
$(".left_sidebar_menu_icon_visible").removeClass("left_sidebar_menu_icon_visible");
}